Fix high memory usage regression due to namespaces #132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the high memory usage regression that was introduced in 2.6.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the high memory usage regression that was introduced in 2.6.2.
This fixes issue #122
Without this commit, when I try to parse a 33MB xlsx file (500_000 rows) and it consumes 8GB. With this commit it's consuming few hundreds (~300MB)
The reason lies in the namespaces due to all hash instantiation it does for all nodes.
Before this commit:
Screencast from 2025-05-27 09-54-59.webm
With this commit:
Screencast from 2025-05-27 09-58-59.webm