Skip to content

Conversation

sayantan1410
Copy link
Contributor

Fix #201

What is the purpose of this pull request?

  • New feature

Let me know if I something needs to be changed.

@netlify
Copy link

netlify bot commented Jan 25, 2022

✔️ Deploy Preview for code-generator ready!

🔨 Explore the source changes: 9f0ab87

🔍 Inspect the deploy log: https://app.netlify.com/sites/code-generator/deploys/61f0fe9cd8d1ab0008239145

😎 Browse the preview: https://deploy-preview-203--code-generator.netlify.app/

@sayantan1410
Copy link
Contributor Author

@vfdev-5 I ran this bash scripts/run_code_style.sh lint but it did not make any changes, while the ci/lint test is failing, can you tell me why ?

@vfdev-5
Copy link
Member

vfdev-5 commented Jan 25, 2022

@sayantan1410 thanks for the PR, almost good. Two things to fix:

Here is current PR preview: https://deploy-preview-203--code-generator.netlify.app/create
where you can see that even while choosing backend as gloo, the command still contains nccl:
image

@ydcjeff
Copy link
Contributor

ydcjeff commented Jan 25, 2022

@sayantan1410 if you have installed npm packages, you can run pnpm run fmt to auto format.

Copy link
Member

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the PR @sayantan1410 !
LGTM

@vfdev-5 vfdev-5 merged commit bc47061 into pytorch-ignite:main Jan 26, 2022
@sayantan1410
Copy link
Contributor Author

@ydcjeff thanks that worked !!
@vfdev-5 thanks for merging !!

@sayantan1410 sayantan1410 deleted the issue201 branch January 29, 2022 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants