Removed DiskHandler wrapper in Checkpoint calls#72
Removed DiskHandler wrapper in Checkpoint calls#72Priyansi merged 2 commits intopytorch-ignite:mainfrom
Conversation
|
@Priyansi the diff is huge even though changes are minimum -- making changes to one of the files (02-convert-pytorch-to-ignite) automatically introduced some new changes -- perhaps indentation introduced via the IDE? |
| "\n", | ||
| "def get_save_handler(config):\n", | ||
| " return DiskSaver(config[\"output_path_\"], require_empty=False)" | ||
| " return config[\"output_path_\"]" |
There was a problem hiding this comment.
Hi @anirudhb11 thanks for the changes! Since now it is returning only a path (and not a handler) should we change the name of the function to something like get_save_path ?
There was a problem hiding this comment.
I thought over this, you're right that it returns the path, but if we do this we would have code like: save_handler=get_save_path(config) in some places which might also not be good. Something that would look better would be to modify it to save_path=get_save_path(config) and then we also change the Checkpoint class to take in save_path instead of save_handler. Let me know your thoughts.
|
Hey @anirudhb11 thanks for the PR! Could you also removes instances of |
@Priyansi I have addressed this. |
3 participants
The following PR addresses #53 by replacing all instances of
save_handler = DiskHandler()