-
Notifications
You must be signed in to change notification settings - Fork 308
feat: RGS for wanda++ #2537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
namgyu-youn
wants to merge
5
commits into
pytorch:main
Choose a base branch
from
namgyu-youn:wanda_pp_rgs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: RGS for wanda++ #2537
+229
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/2537
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
@pytorchbot label "sparsity" |
15 tasks
- Since WandaPlusPlusSparsifier is still in prototype stage, we move it to the prototype directory.
@pytorchbot label "topic: not user facing" |
- Since WandaPlusPlusSparsifier is still in prototype stage, we move it to the prototype directory. update annotations and remove rebudnat error handler update indexing logics for Wanda++ using Wanda - Since both paper uses same index logics (extraction, sorting, and updating), Wanda++ can use the same logic as Wanda. - For using it, `_apply_sparsity_pattern` is moduled to be used in both Wanda and Wanda++. remove hardware-specific test case - This test case is not fully implemented in `wanda_pp.py`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
sparsity
topic: not user facing
Use this tag if you don't want this PR to show up in release notes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update introduces one of the main concepts of Wanda++ (arXiv), Regional Gradient Score (RGS).
Algorithm : RGS
RGS uses block-level gradients instead of magnitude (Wanda):
G_ij
: Regional gradient||X_j||_2
: Activation norm (same in Wanda)|W_ij|
: Weight magnitude (same in Wanda)α
: Regional gradient weight (default: 100 from paper)Algorithm : Wanda++