Skip to content

Commit

Permalink
Build audio with VS2022 (#3878)
Browse files Browse the repository at this point in the history
  • Loading branch information
huydhn authored Feb 7, 2025
1 parent 2709b65 commit f084f34
Show file tree
Hide file tree
Showing 10 changed files with 5 additions and 340 deletions.
3 changes: 0 additions & 3 deletions .github/workflows/unittest-windows-gpu.yml
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,5 @@ jobs:
.github/scripts/unittest-windows/setup_env.sh
./packaging/windows/internal/cuda_install.bat
./packaging/windows/internal/driver_update.bat
.github/scripts/unittest-windows/install.sh
.github/scripts/unittest-windows/run_test.sh
6 changes: 3 additions & 3 deletions docs/source/build.windows.rst
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@ Please follow the instruction at https://visualstudio.microsoft.com/downloads/,

.. note::

The official binary distribution are compiled with MSVC 2019.
The following section uses path from MSVC 2019 Community Edition.
The official binary distribution are compiled with MSVC 2022.
The following section uses path from MSVC 2022 Community Edition.

Conda
~~~~~
Expand Down Expand Up @@ -66,7 +66,7 @@ The following combination is known to work.

.. code-block::
call "C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Auxiliary\Build\vcvarsall.bat" x64
call "C:\Program Files (x86)\Microsoft Visual Studio\2022\Community\VC\Auxiliary\Build\vcvarsall.bat" x64
Please makes sure that ``cl`` command is recognized.

Expand Down
4 changes: 2 additions & 2 deletions packaging/vc_env_helper.bat
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
@echo on

set VC_VERSION_LOWER=16
set VC_VERSION_UPPER=17
set VC_VERSION_LOWER=17
set VC_VERSION_UPPER=18

for /f "usebackq tokens=*" %%i in (`"%ProgramFiles(x86)%\Microsoft Visual Studio\Installer\vswhere.exe" -legacy -products * -version [%VC_VERSION_LOWER%^,%VC_VERSION_UPPER%^) -property installationPath`) do (
if exist "%%i" if exist "%%i\VC\Auxiliary\Build\vcvarsall.bat" (
Expand Down
44 changes: 0 additions & 44 deletions packaging/vs2019/activate.bat

This file was deleted.

21 changes: 0 additions & 21 deletions packaging/vs2019/conda_build_config.yaml

This file was deleted.

27 changes: 0 additions & 27 deletions packaging/vs2019/install_activate.bat

This file was deleted.

49 changes: 0 additions & 49 deletions packaging/vs2019/install_runtime.bat

This file was deleted.

24 changes: 0 additions & 24 deletions packaging/vs2019/meta.yaml

This file was deleted.

142 changes: 0 additions & 142 deletions packaging/windows/internal/cuda_install.bat

This file was deleted.

25 changes: 0 additions & 25 deletions packaging/windows/internal/driver_update.bat

This file was deleted.

0 comments on commit f084f34

Please sign in to comment.