Skip to content

Conversation

samanklesaria
Copy link
Collaborator

@samanklesaria samanklesaria commented Sep 9, 2025

As we've decided against the approach to solving the CI ffmpeg>4 incompatibility issue by installing our own miniconda and ignoring the pytorch-infra environment (begun in #4093), this draft PR tries a different approach: using a standard github runner, as is used to build the docs for torchcodec. Note that this PR depends on files included in #4095 , so it has that PR as a target.

Copy link

pytorch-bot bot commented Sep 9, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/audio/4098

Note: Links to docs will display an error until the docs builds have been completed.

⏳ 6 Pending, 7 Unrelated Failures

As of commit 84d2a99 with merge base f0a4999 (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed label Sep 9, 2025
@samanklesaria samanklesaria changed the base branch from main to new_docs_workflow September 9, 2025 02:56
@pearu pearu added this to the 2.9 milestone Sep 9, 2025
@samanklesaria samanklesaria changed the base branch from new_docs_workflow to main September 9, 2025 16:09
@samanklesaria samanklesaria changed the base branch from main to new_docs_workflow September 9, 2025 16:09
@samanklesaria
Copy link
Collaborator Author

samanklesaria commented Sep 9, 2025

Strange- why isn't CI running any more? Perhaps the force pushing confused github. I had to trigger it manually. The run is at https://github.com/pytorch/audio/actions/runs/17588954128

@samanklesaria
Copy link
Collaborator Author

I'm getting the deadly "Could not load libtorchcodec" error from an incorrectly installed ffmpeg. But conda should be installing ffmpeg correctly! Very confusing.

@samanklesaria samanklesaria changed the base branch from new_docs_workflow to main September 10, 2025 14:23
@pearu pearu changed the title Linux CPU test workflow based on torchcodec docs CI yaml file Revise Linux CPU unittests CI workflow Sep 10, 2025
@pearu
Copy link
Collaborator

pearu commented Sep 10, 2025

I'm getting the deadly "Could not load libtorchcodec" error from an incorrectly installed ffmpeg. But conda should be installing ffmpeg correctly! Very confusing.

I saw this as well. Adding

export LD_LIBRARY_PATH=${CONDA_PREFIX}/lib:${LD_LIBRARY_PATH}

fixed that.

@pearu pearu marked this pull request as ready for review September 11, 2025 07:09
@pearu pearu requested a review from a team as a code owner September 11, 2025 07:09
@pearu pearu requested a review from NicolasHug September 11, 2025 08:06
@pearu pearu force-pushed the alt-cpu-test-workflow branch from b648cdf to 84d2a99 Compare September 11, 2025 11:13
@NicolasHug NicolasHug merged commit caba63f into main Sep 11, 2025
41 of 48 checks passed
@NicolasHug NicolasHug deleted the alt-cpu-test-workflow branch September 11, 2025 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants