Skip to content

Use non-persistent buffers for recomputable transform state #4186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pdTetteh wants to merge 1 commit into
base: main
Choose a base branch
from
+24 −7
Open

Use non-persistent buffers for recomputable transform state #4186

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/torchaudio/transforms/_transforms.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ def __init__(
self.win_length = win_length if win_length is not None else n_fft
self.hop_length = hop_length if hop_length is not None else self.win_length // 2
window = window_fn(self.win_length) if wkwargs is None else window_fn(self.win_length, **wkwargs)
self.register_buffer("window", window)
self.register_buffer("window", window, persistent=False)
self.pad = pad
self.power = power
self.normalized = normalized
Expand Down Expand Up @@ -178,7 +178,7 @@ def __init__(
self.win_length = win_length if win_length is not None else n_fft
self.hop_length = hop_length if hop_length is not None else self.win_length // 2
window = window_fn(self.win_length) if wkwargs is None else window_fn(self.win_length, **wkwargs)
self.register_buffer("window", window)
self.register_buffer("window", window, persistent=False)
self.pad = pad
self.normalized = normalized
self.center = center
Expand Down Expand Up @@ -974,7 +974,7 @@ def __init__(
beta,
dtype=dtype,
)
self.register_buffer("kernel", kernel)
self.register_buffer("kernel", kernel, persistent=False)

def forward(self, waveform: Tensor) -> Tensor:
r"""
Expand Down
25 changes: 21 additions & 4 deletions test/torchaudio_unittest/transforms/transforms_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,18 +238,35 @@ def test_resample_size(self):
sample_rate, upsample_rate, resampling_method="sinc_interp_hann"
)
up_sampled = upsample_resample(waveform)

# we expect the upsampled signal to have twice as many samples
self.assertTrue(up_sampled.size(-1) == waveform.size(-1) * 2)

downsample_resample = torchaudio.transforms.Resample(
sample_rate, downsample_rate, resampling_method="sinc_interp_hann"
)
down_sampled = downsample_resample(waveform)

# we expect the downsampled signal to have half as many samples
self.assertTrue(down_sampled.size(-1) == waveform.size(-1) // 2)


def test_spectrogram_window_not_in_state_dict(self):
transform = transforms.Spectrogram()
state_dict = transform.state_dict()

self.assertNotIn("window", state_dict)


def test_inverse_spectrogram_window_not_in_state_dict(self):
transform = transforms.InverseSpectrogram(n_fft=400)
state_dict = transform.state_dict()

self.assertNotIn("window", state_dict)


def test_resample_kernel_not_in_state_dict(self):
transform = transforms.Resample(orig_freq=16000, new_freq=8000)
state_dict = transform.state_dict()

self.assertNotIn("kernel", state_dict)

def test_compute_deltas(self):
channel = 13
n_mfcc = channel * 3
Expand Down