-
Notifications
You must be signed in to change notification settings - Fork 529
NXP backend: Enable initial unit tests workflow #10258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
NXP backend: Enable initial unit tests workflow #10258
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10258
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 879128d with merge base 4559a61 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
@pytorchbot label "module: nxp" |
@pytorchbot label "release notes: nxp" |
cd $EXECUTORCH_DIR | ||
|
||
# '-c /dev/null' is used to ignore root level pytest.ini. | ||
PYTHONPATH=`cd ..; pwd` pytest -c /dev/null backends/nxp/tests/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have to use pytest
? Can we start with just the unit tests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We use pytest quite extensively - fixtures, mocking/spying, test parametrization, test skipping etc. Tests in Robert's PR are also based on pytest so it would require significant refactoring - https://github.com/pytorch/executorch/pull/10196/files#diff-5103e16cc6c48b276ba322c235272453e0442b6d19193200cd4a0e95706a605c . So if there's chance to stick with pytest, we would prefer it.
.github/workflows/pull.yml
Outdated
|
||
# Build and install Executorch | ||
PYTHON_EXECUTABLE=python \ | ||
CMAKE_ARGS="-DEXECUTORCH_BUILD_PYBIND=ON -DEXECUTORCH_BUILD_NXP_NEUTRON=ON" \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious, why do we need to enable PYBIND
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, this is my misunderstanding of how EXECUTORCH_BUILD_PYBIND
should be used. I have considered it as a "mechanism to build backend-specific dependencies", because I needed to build portable_lib
and also libquantized_ops_aot_lib
. Removed.
a850383
to
879128d
Compare
Summary
Initial workflow definition for running unit tests for Neutron (NXP) backend.
cc @digantdesai @JakeStevens @robert-kalmar