Skip to content

NXP backend: Enable initial unit tests workflow #10258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

skywall
Copy link
Contributor

@skywall skywall commented Apr 17, 2025

Summary

Initial workflow definition for running unit tests for Neutron (NXP) backend.

cc @digantdesai @JakeStevens @robert-kalmar

Copy link

pytorch-bot bot commented Apr 17, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10258

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 879128d with merge base 4559a61 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 17, 2025
@skywall
Copy link
Contributor Author

skywall commented Apr 17, 2025

@pytorchbot label "module: nxp"

@pytorch-bot pytorch-bot bot added the module: nxp Issues related to NXP Neutron NPU delegation and code under backends/nxp/ label Apr 17, 2025
@skywall
Copy link
Contributor Author

skywall commented Apr 17, 2025

@pytorchbot label "release notes: nxp"

@pytorch-bot pytorch-bot bot added the release notes: nxp Changes to the NXP Neutron backend delegate label Apr 17, 2025
cd $EXECUTORCH_DIR

# '-c /dev/null' is used to ignore root level pytest.ini.
PYTHONPATH=`cd ..; pwd` pytest -c /dev/null backends/nxp/tests/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have to use pytest? Can we start with just the unit tests?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use pytest quite extensively - fixtures, mocking/spying, test parametrization, test skipping etc. Tests in Robert's PR are also based on pytest so it would require significant refactoring - https://github.com/pytorch/executorch/pull/10196/files#diff-5103e16cc6c48b276ba322c235272453e0442b6d19193200cd4a0e95706a605c . So if there's chance to stick with pytest, we would prefer it.


# Build and install Executorch
PYTHON_EXECUTABLE=python \
CMAKE_ARGS="-DEXECUTORCH_BUILD_PYBIND=ON -DEXECUTORCH_BUILD_NXP_NEUTRON=ON" \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious, why do we need to enable PYBIND?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, this is my misunderstanding of how EXECUTORCH_BUILD_PYBIND should be used. I have considered it as a "mechanism to build backend-specific dependencies", because I needed to build portable_lib and also libquantized_ops_aot_lib. Removed.

@skywall skywall force-pushed the feature/nxf93343/neutron-unittest-ci branch from a850383 to 879128d Compare April 22, 2025 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: nxp Issues related to NXP Neutron NPU delegation and code under backends/nxp/ release notes: nxp Changes to the NXP Neutron backend delegate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants