Skip to content

[cortex-m] Add scalar c++ op for quantize_per_tensor #10266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 23, 2025

Conversation

digantdesai
Copy link
Contributor

@digantdesai digantdesai commented Apr 17, 2025

Stack from ghstack (oldest at bottom):

Only buck build for now, CMake is next.
No MVE, scalar only.
Strictly the dtypes we care about update arg_meta to reflect that.

Differential Revision: D73141767

NOTE FOR REVIEWERS: This PR has internal Meta-specific changes or comments, please review them on Phabricator!

Only buck build for now, CMake is next.
No MVE, scalar only.
Strictly the dtypes we care about update arg_meta to reflect that.

Differential Revision: [D73141767](https://our.internmc.facebook.com/intern/diff/D73141767/)

**NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D73141767/)!

[ghstack-poisoned]
Copy link

pytorch-bot bot commented Apr 17, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10266

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures

As of commit 1d2ba35 with merge base b5e8ee9 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 17, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D73141767

Only buck build for now, CMake is next.
No MVE, scalar only.
Strictly the dtypes we care about update arg_meta to reflect that.

Differential Revision: [D73141767](https://our.internmc.facebook.com/intern/diff/D73141767/)

**NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D73141767/)!

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D73141767

Only buck build for now, CMake is next.
No MVE, scalar only.
Strictly the dtypes we care about update arg_meta to reflect that.

Differential Revision: [D73141767](https://our.internmc.facebook.com/intern/diff/D73141767/)

**NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D73141767/)!

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D73141767

Only buck build for now, CMake is next.
No MVE, scalar only.
Strictly the dtypes we care about update arg_meta to reflect that.

Differential Revision: [D73141767](https://our.internmc.facebook.com/intern/diff/D73141767/)

**NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D73141767/)!

[ghstack-poisoned]
Only buck build for now, CMake is next.
No MVE, scalar only.
Strictly the dtypes we care about update arg_meta to reflect that.

Differential Revision: [D73141767](https://our.internmc.facebook.com/intern/diff/D73141767/)

**NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D73141767/)!

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D73141767

@facebook-github-bot facebook-github-bot merged commit afc22c6 into gh/digantdesai/32/base Apr 23, 2025
82 of 86 checks passed
@facebook-github-bot facebook-github-bot deleted the gh/digantdesai/32/head branch April 23, 2025 04:23
jackzhxng pushed a commit that referenced this pull request Apr 24, 2025
Pull Request resolved: #10266

Only buck build for now, CMake is next.
No MVE, scalar only.
Strictly the dtypes we care about update arg_meta to reflect that.
ghstack-source-id: 279606181
@exported-using-ghexport

Differential Revision: [D73141767](https://our.internmc.facebook.com/intern/diff/D73141767/)

**NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D73141767/)!
jackzhxng pushed a commit that referenced this pull request Apr 24, 2025
This PR was created by the merge bot to help merge the original PR into
the main branch.
ghstack PR number: #10266 by
@digantdesai
^ Please use this as the source of truth for the PR details, comments,
and reviews
ghstack PR base:
https://github.com/pytorch/executorch/tree/gh/digantdesai/32/base
ghstack PR head:
https://github.com/pytorch/executorch/tree/gh/digantdesai/32/head
Merge bot PR base:
https://github.com/pytorch/executorch/tree/gh/digantdesai/31/orig
Merge bot PR head:
https://github.com/pytorch/executorch/tree/gh/digantdesai/32/orig
@diff-train-skip-merge

Co-authored-by: Digant Desai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants