Skip to content

Fixed inaccurate PR labelling instructions #10268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jhelsby
Copy link
Contributor

@jhelsby jhelsby commented Apr 17, 2025

Summary

Previously, the new contributor guide claimed non-maintainers couldn't label their PRs. This update fixes that, providing instructions on how to make pytorchbot to add a label.

Previously, the new contributor guide claimed non-maintainers couldn't
label their PRs. This update fixes that and provides instructions on how
to get pytorchbot to add a label.
Copy link

pytorch-bot bot commented Apr 17, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10268

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 2078c88 with merge base cb80092 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 17, 2025
@jhelsby
Copy link
Contributor Author

jhelsby commented Apr 17, 2025

@pytorchbot label "topic: not user facing"

@jhelsby jhelsby marked this pull request as ready for review April 17, 2025 17:47
@jhelsby jhelsby requested a review from mergennachin as a code owner April 17, 2025 17:47
@byjlw byjlw self-requested a review April 18, 2025 15:46
@jhelsby
Copy link
Contributor Author

jhelsby commented Apr 18, 2025

Many thanks for the review - could somebody please merge / run the workflows which need approval so I can merge? Thanks!

@byjlw byjlw merged commit 96c10bb into pytorch:main Apr 21, 2025
5 of 7 checks passed
keyprocedure pushed a commit to keyprocedure/executorch that referenced this pull request Apr 21, 2025
### Summary

Previously, the new contributor guide claimed non-maintainers couldn't
label their PRs. This update fixes that, providing instructions on how
to make pytorchbot to add a label.

Co-authored-by: jhels <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants