Remove args from LLMEdgeManager and misc cleanup #10288
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackzhxng
requested review from
iseeyuan,
larryliu0820,
swolchok and
lucylq
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10288
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 2 New Failures, 52 Pending, 2 Unrelated FailuresAs of commit 8707043 with merge base cbca483 ( NEW FAILURES - The following jobs have failed:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
BROKEN TRUNK - The following job failed but was present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
@jackzhxng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
jackzhxng
added
the
release notes: examples
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 18, 2025
Summary: Decouple `export_llama`'s `argparse.namespace` from `LLMEdgeManager` + misc cleanup Test Plan: CI Differential Revision: D73225183 Pulled By: jackzhxng
facebook-github-bot
force-pushed
the
jz/llm-edge-manager-cleanup
branch
from
4e82b57 to
43e029b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D73225183 |
iseeyuan
approved these changes
Apr 18, 2025
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 18, 2025
Summary: Decouple `export_llama`'s `argparse.namespace` from `LLMEdgeManager` + misc cleanup Test Plan: CI Reviewed By: iseeyuan Differential Revision: D73225183 Pulled By: jackzhxng
facebook-github-bot
force-pushed
the
jz/llm-edge-manager-cleanup
branch
from
43e029b to
8e1b057
Compare
|
This pull request was exported from Phabricator. Differential Revision: D73225183 |
Summary: Decouple `export_llama`'s `argparse.namespace` from `LLMEdgeManager` + misc cleanup Test Plan: CI Reviewed By: iseeyuan Differential Revision: D73225183 Pulled By: jackzhxng
facebook-github-bot
force-pushed
the
jz/llm-edge-manager-cleanup
branch
from
8e1b057 to
8707043
Compare
|
This pull request was exported from Phabricator. Differential Revision: D73225183 |
keyprocedure
pushed a commit
to keyprocedure/executorch
that referenced
this pull request
Apr 21, 2025
Differential Revision: D73225183 Pull Request resolved: pytorch#10288
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Decouple
export_llama'sargparse.namespacefromLLMEdgeManager+ misc cleanupTest plan
CI