Skip to content

Qualcomm AI Engine Direct - GA Model Enablement (Roberta) #11354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 16, 2025

Conversation

chenweng-quic
Copy link
Contributor

Summary

  • support e2e script / test case for GA RoBERTa model
  • perf: 16a8w 79.2ms/inf (SM8750) (seq_len=107)
  • acc: ~= 50%

Test plan

python backends/qualcomm/tests/test_qnn_delegate.py -k TestExampleOssScript.test_roberta --device <device_id> --host <host> --model <soc_model> --build_folder build-android --executorch_root . --sentence_dataset wikisent2.txt --artifact roberta_artifact

@chenweng-quic chenweng-quic requested a review from cccclai as a code owner June 4, 2025 06:13
Copy link

pytorch-bot bot commented Jun 4, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11354

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit fe5089a with merge base e02ca41 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 4, 2025
@chenweng-quic
Copy link
Contributor Author

@pytorchbot label "release notes: qualcomm"

@pytorch-bot pytorch-bot bot added the release notes: qualcomm Changes to the Qualcomm backend delegate label Jun 4, 2025
@chenweng-quic chenweng-quic changed the title Add QNN backend end to end script for Roberta model Qualcomm AI Engine Direct - GA Model Enablement (Roberta) Jun 4, 2025
@haowhsu-quic
Copy link
Collaborator

Hi @cccclai, we have 4 GA BERT variants depend on this PR, will submit them after this got merged. It's just FYI, please take your time, no rush.
Thank you!

@haowhsu-quic
Copy link
Collaborator

And looks like it's not triggering CI, could you help on it?

@facebook-github-bot
Copy link
Contributor

@cccclai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@cccclai
Copy link
Contributor

cccclai commented Jun 6, 2025

There is a lint error, can you fix it?

chenweng-quic and others added 2 commits June 9, 2025 09:41
- Add end to end script for Roberta
- Handle extreme values in replace_inf function for masked_fill
@chenweng-quic chenweng-quic force-pushed the dev1/chenweng/roberta branch from 32dd145 to fe5089a Compare June 9, 2025 01:41
@facebook-github-bot
Copy link
Contributor

@cccclai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Copy link
Contributor

@cccclai cccclai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@facebook-github-bot
Copy link
Contributor

@cccclai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@cccclai cccclai merged commit a23ed73 into pytorch:main Jun 16, 2025
103 of 104 checks passed
abhinaykukkadapu pushed a commit to abhinaykukkadapu/executorch that referenced this pull request Jun 17, 2025
)

### Summary
- support e2e script / test case for GA RoBERTa model
- perf: 16a8w 79.2ms/inf (SM8750) (seq_len=107)
- acc: ~= 50%

### Test plan
```
python backends/qualcomm/tests/test_qnn_delegate.py -k TestExampleOssScript.test_roberta --device <device_id> --host <host> --model <soc_model> --build_folder build-android --executorch_root . --sentence_dataset wikisent2.txt --artifact roberta_artifact
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: qualcomm Changes to the Qualcomm backend delegate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants