[3/N] Add update function in backend interface #11391
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add update function in backend interface class. Next step, will add update API in the method and then module Differential Revision: [D75919242](https://our.internmc.facebook.com/intern/diff/D75919242/) [ghstack-poisoned]
This was referenced Jun 5, 2025
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11391
Note: Links to docs will display an error until the docs builds have been completed. ❌ 82 New Failures, 1 Unrelated FailureAs of commit f2249b3 with merge base b4bd556 ( NEW FAILURES - The following jobs have failed:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
cccclai
added a commit
that referenced
this pull request
Jun 5, 2025
Add update function in backend interface class. Next step, will add update API in the method and then module Differential Revision: [D75919242](https://our.internmc.facebook.com/intern/diff/D75919242/) ghstack-source-id: 288333606 Pull Request resolved: #11391
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D75919242 |
This PR needs a
|
cccclai
requested review from
digantdesai,
mergennachin,
SS-JIA,
kimishpatel,
JacobSzwejbka,
mcr229 and
metascroy
kimishpatel
reviewed
Jun 6, 2025
| @@ -117,6 +118,10 @@ class BackendOptions { | |||
| return err; | |||
| } | |||
|
|
|||
| executorch::runtime::ArrayRef<BackendOption> view() const { | |||
There was a problem hiding this comment.
maybe more meaningful name. get_backend_options or get_ref_to_backend_options
Add update function in backend interface class. Next step, will add update API in the method and then module Differential Revision: [D75919242](https://our.internmc.facebook.com/intern/diff/D75919242/) [ghstack-poisoned]
This was referenced Jun 6, 2025
|
This pull request was exported from Phabricator. Differential Revision: D75919242 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Add update function in backend interface class.
Next step, will add update API in the method and then module
Differential Revision: D75919242