[ET-VK][Ops] dequantize_per_tensor.default test setup #11481
Conversation
Creating dequantize_per_tensor testing framework along with a reference implementation for testing Differential Revision: [D76267054](https://our.internmc.facebook.com/intern/diff/D76267054/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11481
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D76267054 |
Creating dequantize_per_tensor testing framework along with a reference implementation for testing Differential Revision: [D76267054](https://our.internmc.facebook.com/intern/diff/D76267054/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D76267054 |
Creating dequantize_per_tensor testing framework along with a reference implementation for testing Differential Revision: [D76267054](https://our.internmc.facebook.com/intern/diff/D76267054/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D76267054 |
| ASSERT_TRUE(output_correct); | ||
| } | ||
|
|
||
| // Test cases for dequantize_per_tensor |
There was a problem hiding this comment.
also add tests for int32 and int64
There was a problem hiding this comment.
theres no real support for int64 in the shader. right now dequantize matches the IO for quantize which include half, float and then uint8, int8, and int32 as common dtypes and to avoid generating excess variants. if int64 is a necessary variant I'll make those changes in a future diff.
there is a diff that adds double support (though really just fp32 underneath)
i will add more tests in this diff.
There was a problem hiding this comment.
As @ahmtox has pointed out, to reduce binary size Vulkan kind of takes the opposite approach of the portable kernels, which means supporting the minimum dtypes necessary i.e. basically what we would expect to encounter in a "real" model.
Creating dequantize_per_tensor testing framework along with a reference implementation for testing Differential Revision: [D76267054](https://our.internmc.facebook.com/intern/diff/D76267054/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D76267054 |
Creating dequantize_per_tensor testing framework along with a reference implementation for testing Differential Revision: [D76267054](https://our.internmc.facebook.com/intern/diff/D76267054/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D76267054 |
Creating dequantize_per_tensor testing framework along with a reference implementation for testing Differential Revision: [D76267054](https://our.internmc.facebook.com/intern/diff/D76267054/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D76267054 |
Creating dequantize_per_tensor testing framework along with a reference implementation for testing Differential Revision: [D76267054](https://our.internmc.facebook.com/intern/diff/D76267054/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D76267054 |
Creating dequantize_per_tensor testing framework along with a reference implementation for testing Differential Revision: [D76267054](https://our.internmc.facebook.com/intern/diff/D76267054/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D76267054 |
Stack from ghstack (oldest at bottom):
Creating dequantize_per_tensor testing framework along with a reference implementation for testing
Differential Revision: D76267054