-
Notifications
You must be signed in to change notification settings - Fork 635
Log info instead of error #12638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log info instead of error #12638
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12638
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 2 Pending, 4 Unrelated FailuresAs of commit 86e2cd0 with merge base d3d94dd ( NEW FAILURE - The following job has failed:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
BROKEN TRUNK - The following jobs failed but was present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
@@ -227,7 +227,7 @@ Result<executorch_flatbuffer::ExecutionPlan*> get_execution_plan( | |||
// For support, contact the PyTorch Edge team or make an issue in: | |||
// https://github.com/pytorch/executorch/issues. | |||
ET_LOG( | |||
Error, | |||
Info, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So is our plan to keep this functional for a while more and then delete it?
Else we shouldn't merge this, if we really want to deprecate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah - it's currently deprecated AoT (since ET beta) so we should deprecate it in the runtime. There are a bunch of tests/users with older PTEs, and they will fail if this branch is removed now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But if the older
PTEs are outside of the BC window, then we should perhaps start nudging people to update their PRs. This is one way, pinging them with a deadline is another :p
Fix failing jobs caused by error logging from #12295
Test failures: https://hud.pytorch.org/pr/pytorch/executorch/12631#46239138027
Note: logging errors doesn't cause an abort in the et runtime; seems like the arm test is being extra careful and parsing the log script for errors, which is causing this failure.
executorch/backends/arm/scripts/run_fvp.sh
Lines 111 to 117 in aab8021