Skip to content

Log info instead of error #12638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Log info instead of error #12638

wants to merge 1 commit into from

Conversation

lucylq
Copy link
Contributor

@lucylq lucylq commented Jul 18, 2025

Fix failing jobs caused by error logging from #12295

Test failures: https://hud.pytorch.org/pr/pytorch/executorch/12631#46239138027

Note: logging errors doesn't cause an abort in the et runtime; seems like the arm test is being extra careful and parsing the log script for errors, which is causing this failure.

echo "Checking for problems in log:"
! grep -E "^(F|E|\\[critical\\]|Hard fault.|Info: Simulation is stopping. Reason: CPU time has been exceeded.).*$" ${log_file}
if [ $? != 0 ]; then
echo "Found ERROR"
rm "${log_file}"
exit 1
fi

Copy link

pytorch-bot bot commented Jul 18, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12638

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 2 Pending, 4 Unrelated Failures

As of commit 86e2cd0 with merge base d3d94dd (image):

NEW FAILURE - The following job has failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 18, 2025
@lucylq lucylq requested a review from digantdesai July 18, 2025 16:15
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@@ -227,7 +227,7 @@ Result<executorch_flatbuffer::ExecutionPlan*> get_execution_plan(
// For support, contact the PyTorch Edge team or make an issue in:
// https://github.com/pytorch/executorch/issues.
ET_LOG(
Error,
Info,
Copy link
Contributor

@digantdesai digantdesai Jul 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So is our plan to keep this functional for a while more and then delete it?
Else we shouldn't merge this, if we really want to deprecate.

Copy link
Contributor Author

@lucylq lucylq Jul 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah - it's currently deprecated AoT (since ET beta) so we should deprecate it in the runtime. There are a bunch of tests/users with older PTEs, and they will fail if this branch is removed now.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But if the older PTEs are outside of the BC window, then we should perhaps start nudging people to update their PRs. This is one way, pinging them with a deadline is another :p

@lucylq lucylq closed this Jul 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants