Add test when there are no segments #12646

lucylq · 2025-07-18T17:40:34Z

Summary:
The deprecation warning should only appear when there are values inside the constant_buffer and nothing inside the constant_segment.

Even when there are no constants in the program, we expect to have one 'segment' storing the placeholder for non-constants.

Fix failing jobs caused by error logging from #12295
Test failures: https://hud.pytorch.org/pr/pytorch/executorch/12631#46239138027

Arm test is using a recently-generated PTE, however hitting the deprecation warning because the pte has no constants.

Differential Revision: D78568839

pytorch-bot · 2025-07-18T17:40:38Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12646

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 1 Unrelated Failure

As of commit 4197bc2 with merge base c9df2aa ():

NEW FAILURES - The following jobs have failed:

pull / test-eval_llama-mmlu-linux / linux-job (gh)
RuntimeError: Command docker exec -t 6984c4f66f8103381e973d57617392747db44533ef93537bbca7a71ad4b4d97a /exec failed with exit code 1
trunk / unittest-release / macos / macos-job (gh)
backends/xnnpack/test/ops/test_conv1d.py::TestConv1d::test_qs8_conv1d_batchnorm_seq

FLAKY - The following job failed but was likely due to flakiness present on trunk:

pull / test-llama-runner-qnn-linux (fp32, qnn_8a8w, qnn) / linux-job (gh) (matched linux rule in flaky-rules.json)
The process '/usr/bin/git' failed with exit code 128

This comment was automatically generated by Dr. CI and updates every 15 minutes.

facebook-github-bot · 2025-07-18T17:40:44Z

This pull request was exported from Phabricator. Differential Revision: D78568839

github-actions · 2025-07-18T17:41:19Z

This PR needs a `release notes:` label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Summary: The deprecation warning should only appear when there are values inside the constant_buffer and nothing inside the constant_segment. Even when there are no constants in the program, we expect to have one 'segment' storing the placeholder for non-constants. Fix failing jobs caused by error logging from pytorch#12295 Test failures: https://hud.pytorch.org/pr/pytorch/executorch/12631#46239138027 Arm test is using a recently-generated PTE, however hitting the deprecation warning because the pte has no constants. Differential Revision: D78568839

facebook-github-bot · 2025-07-18T20:40:30Z

This pull request was exported from Phabricator. Differential Revision: D78568839

digantdesai · 2025-07-18T21:12:16Z

runtime/executor/program.cpp

+      // https://github.com/pytorch/executorch/issues.
+      ET_LOG(
+          Error,
+          "!!DEPRECATED!! This branch is deprecated from ExecuTorch 0.7; re-export this PTE file to ensure support on newer runtimes.");


Nit: can we explain a bit more in the error message, and perhaps how to mitigate it? Seems like one has to read code to get around this error.

I previously had a longer message, but this caused errors in internal tests where they have a limit of 128 bytes for the log string - see D77965467

Summary: The deprecation warning should only appear when there are values inside the constant_buffer and nothing inside the constant_segment. Even when there are no constants in the program, we expect to have one 'segment' storing the placeholder for non-constants. Fix failing jobs caused by error logging from pytorch#12295 Test failures: https://hud.pytorch.org/pr/pytorch/executorch/12631#46239138027 Arm test is using a recently-generated PTE, however hitting the deprecation warning because the pte has no constants. Differential Revision: D78568839

facebook-github-bot · 2025-07-18T22:31:57Z

This pull request was exported from Phabricator. Differential Revision: D78568839

Summary: The deprecation warning should only appear when there are values inside the constant_buffer and nothing inside the constant_segment. Even when there are no constants in the program, we expect to have one 'DataSegment' storing the placeholder for non-constants. Fix failing jobs caused by error logging from pytorch#12295 Test failures: https://hud.pytorch.org/pr/pytorch/executorch/12631#46239138027 Arm test is using a recently-generated PTE, however hitting the deprecation warning because the pte has no constants. Reviewed By: larryliu0820 Differential Revision: D78568839

facebook-github-bot · 2025-07-18T22:55:08Z

This pull request was exported from Phabricator. Differential Revision: D78568839

Summary: The deprecation warning should only appear when there are values inside the constant_buffer and nothing inside the constant_segment. Even when there are no constants in the program, we expect to have one 'DataSegment' storing the placeholder for non-constants. Move this into the 'if' branch. Fix failing jobs caused by error logging from pytorch#12295 Test failures: https://hud.pytorch.org/pr/pytorch/executorch/12631#46239138027 Arm test is using a recently-generated PTE, however hitting the deprecation warning because the pte has no constants. Reviewed By: larryliu0820 Differential Revision: D78568839

facebook-github-bot · 2025-07-18T23:08:48Z

This pull request was exported from Phabricator. Differential Revision: D78568839

lucylq · 2025-07-21T20:46:46Z

@pytorchbot cherry-pick --onto release/0.7 -c {release; add log for deprecated feature}

pytorch-bot · 2025-07-21T20:46:48Z

❌ 🤖 pytorchbot command failed:

@pytorchbot cherry-pick: error: argument -c/--classification: invalid choice: '{release;' (choose from 'regression', 'critical', 'fixnewfeature', 'docs', 'release')

usage: @pytorchbot cherry-pick --onto ONTO [--fixes FIXES] -c
                               {regression,critical,fixnewfeature,docs,release}

Try @pytorchbot --help for more info.

lucylq · 2025-07-21T20:47:20Z

@pytorchbot cherry-pick --onto release/0.7 -c {release}

pytorch-bot · 2025-07-21T20:47:23Z

❌ 🤖 pytorchbot command failed:

@pytorchbot cherry-pick: error: argument -c/--classification: invalid choice: '{release}' (choose from 'regression', 'critical', 'fixnewfeature', 'docs', 'release')

usage: @pytorchbot cherry-pick --onto ONTO [--fixes FIXES] -c
                               {regression,critical,fixnewfeature,docs,release}

Try @pytorchbot --help for more info.

lucylq · 2025-07-21T20:47:52Z

@pytorchbot cherry-pick --onto release/0.7 -c release

Differential Revision: D78568839 Pull Request resolved: #12646 (cherry picked from commit 4d7f9ca)

pytorchbot · 2025-07-21T20:49:59Z

Cherry picking #12646

The cherry pick PR is at #12687 The following tracker issues are updated:

[v0.7.0] Release Tracker #11075 (comment)

Details for Dev Infra team

Raised by workflow job

Differential Revision: D78568839 Pull Request resolved: pytorch#12646

lucylq requested review from JacobSzwejbka and swolchok as code owners July 18, 2025 17:40

meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 18, 2025

facebook-github-bot added the fb-exported label Jul 18, 2025

lucylq force-pushed the export-D78568839 branch from 81cca29 to 976f952 Compare July 18, 2025 20:40

digantdesai reviewed Jul 18, 2025

View reviewed changes

digantdesai approved these changes Jul 18, 2025

View reviewed changes

lucylq force-pushed the export-D78568839 branch from 976f952 to 113a1fe Compare July 18, 2025 22:31

lucylq force-pushed the export-D78568839 branch from 113a1fe to 80b4296 Compare July 18, 2025 22:54

lucylq force-pushed the export-D78568839 branch from 80b4296 to 4197bc2 Compare July 18, 2025 23:08

lucylq added the ciflow/trunk label Jul 18, 2025

facebook-github-bot merged commit 4d7f9ca into pytorch:main Jul 19, 2025
199 of 204 checks passed

pytorchbot pushed a commit that referenced this pull request Jul 21, 2025

Add test when there are no segments

78e62aa

Differential Revision: D78568839 Pull Request resolved: #12646 (cherry picked from commit 4d7f9ca)

pytorchbot mentioned this pull request Jul 21, 2025

[v0.7.0] Release Tracker #11075

Open

Conarnar pushed a commit to Conarnar/executorch that referenced this pull request Jul 25, 2025

Add test when there are no segments

982e383

Differential Revision: D78568839 Pull Request resolved: pytorch#12646

Add test when there are no segments #12646

Add test when there are no segments #12646

Uh oh!

Conversation

lucylq commented Jul 18, 2025

Uh oh!

pytorch-bot bot commented Jul 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12646

❌ 2 New Failures, 1 Unrelated Failure

Uh oh!

facebook-github-bot commented Jul 18, 2025

Uh oh!

github-actions bot commented Jul 18, 2025

This PR needs a release notes: label

Uh oh!

facebook-github-bot commented Jul 18, 2025

Uh oh!

digantdesai Jul 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lucylq Jul 18, 2025

Choose a reason for hiding this comment

Uh oh!

facebook-github-bot commented Jul 18, 2025

Uh oh!

facebook-github-bot commented Jul 18, 2025

Uh oh!

facebook-github-bot commented Jul 18, 2025

Uh oh!

Uh oh!

lucylq commented Jul 21, 2025

Uh oh!

pytorch-bot bot commented Jul 21, 2025

Uh oh!

lucylq commented Jul 21, 2025

Uh oh!

pytorch-bot bot commented Jul 21, 2025

Uh oh!

lucylq commented Jul 21, 2025

Uh oh!

pytorchbot commented Jul 21, 2025

Cherry picking #12646

Uh oh!

Uh oh!

pytorch-bot bot commented Jul 18, 2025 •

edited

Loading

This PR needs a `release notes:` label

digantdesai Jul 18, 2025 •

edited

Loading