-
Notifications
You must be signed in to change notification settings - Fork 626
Qualcomm AI Engine Direct - Support min.dim, max.dim and argmax ops #12669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12669
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 1 New FailureAs of commit 5429220 with merge base e31eb56 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
@pytorchbot label "release notes: qualcomm" |
3599379
to
3b81ebf
Compare
Is the PR ready? It seems good to me but it's this pr is in draft |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for quickly adding the ops!
Summary: Rollback Plan: Differential Revision: D78526966
Summary: - Support aten.min.dim, aten.max.dim and aten.argmax
3b81ebf
to
5429220
Compare
Yes, it's ready! I also added a few more comments in the pass to help with readability. |
Summary:
Test plan
aten.min.dim
aten.max.dim
argmax
cc: @haowhsu-quic @cccclai