Skip to content

Qualcomm AI Engine Direct - Support min.dim, max.dim and argmax ops #12669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 23, 2025

Conversation

DannyYuyang-quic
Copy link
Collaborator

Summary:

  • Support aten.min.dim, aten.max.dim and aten.argmax

Test plan

aten.min.dim

python backends/qualcomm/tests/test_qnn_delegate.py TestQNNQuantizedOperators.test_qnn_backend_min_dim -s ${device_id} -H ${host_id} -m ${soc} -b build-android

python backends/qualcomm/tests/test_qnn_delegate.py TestQNNFloatingPointOperator.test_qnn_backend_min_dim -s ${device_id} -H ${host_id} -m ${soc} -b build-android

aten.max.dim

python backends/qualcomm/tests/test_qnn_delegate.py TestQNNQuantizedOperators.test_qnn_backend_max_dim -s ${device_id} -H ${host_id} -m ${soc} -b build-android

python backends/qualcomm/tests/test_qnn_delegate.py TestQNNFloatingPointOperator.test_qnn_backend_max_dim -s ${device_id} -H ${host_id} -m ${soc} -b build-android

argmax

python backends/qualcomm/tests/test_qnn_delegate.py TestQNNQuantizedOperators.test_qnn_backend_argmax -s ${device_id} -H ${host_id} -m ${soc} -b build-android

python backends/qualcomm/tests/test_qnn_delegate.py TestQNNFloatingPointOperator.test_qnn_backend_argmax -s ${device_id} -H ${host_id} -m ${soc} -b build-android

cc: @haowhsu-quic @cccclai

Copy link

pytorch-bot bot commented Jul 21, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12669

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 1 New Failure

As of commit 5429220 with merge base e31eb56 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 21, 2025
@DannyYuyang-quic
Copy link
Collaborator Author

Hi @cccclai ,
This PR covers part of the ops support requested in #12623
Please have a look
Thanks!

@DannyYuyang-quic
Copy link
Collaborator Author

@pytorchbot label "release notes: qualcomm"

@pytorch-bot pytorch-bot bot added the release notes: qualcomm Changes to the Qualcomm backend delegate label Jul 21, 2025
@DannyYuyang-quic DannyYuyang-quic force-pushed the dev1/danny/support_min_dim branch from 3599379 to 3b81ebf Compare July 21, 2025 11:08
@facebook-github-bot
Copy link
Contributor

@cccclai has imported this pull request. If you are a Meta employee, you can view this in D78675516.

@cccclai
Copy link
Contributor

cccclai commented Jul 21, 2025

Is the PR ready? It seems good to me but it's this pr is in draft

Copy link
Contributor

@cccclai cccclai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for quickly adding the ops!

cccclai and others added 2 commits July 22, 2025 11:28
Summary:



Rollback Plan:

Differential Revision: D78526966
Summary:
 - Support aten.min.dim, aten.max.dim and aten.argmax
@DannyYuyang-quic DannyYuyang-quic force-pushed the dev1/danny/support_min_dim branch from 3b81ebf to 5429220 Compare July 22, 2025 03:28
@DannyYuyang-quic DannyYuyang-quic marked this pull request as ready for review July 22, 2025 03:29
@DannyYuyang-quic
Copy link
Collaborator Author

Is the PR ready? It seems good to me but it's this pr is in draft

Yes, it's ready! I also added a few more comments in the pass to help with readability.

@facebook-github-bot
Copy link
Contributor

@cccclai has imported this pull request. If you are a Meta employee, you can view this in D78675516.

@cccclai cccclai merged commit 56b0074 into pytorch:main Jul 23, 2025
100 of 101 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: qualcomm Changes to the Qualcomm backend delegate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants