migrate exir test to use torch.cond instead of the hop directly #12695
+5
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12695
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 1 New FailureAs of commit e45dacb with merge base e31eb56 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D78696006 |
|
@pytorchbot label "release notes: none" |
pytorch-bot
bot
added
the
release notes: none
ydwu4
added a commit
to ydwu4/executorch-1
that referenced
this pull request
Jul 22, 2025
…rch#12695) Summary: torch.cond is the use-facing api, which allows closure, have safety checks etc. Differential Revision: D78696006
…rch#12695) Summary: Pull Request resolved: pytorch#12695 torch.cond is the use-facing api, which allows closure, have safety checks etc. Differential Revision: D78696006
|
This pull request was exported from Phabricator. Differential Revision: D78696006 |
larryliu0820
approved these changes
Jul 22, 2025
|
do torch.map and torch.while exist as well |
|
haven't yet, they can be accessed via torch._higher_order_ops.map/while_loop now |
Conarnar
pushed a commit
to Conarnar/executorch
that referenced
this pull request
Jul 25, 2025
Differential Revision: D78696006 Pull Request resolved: pytorch#12695
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: torch.cond is the use-facing api, which allows closure, have safety checks etc.
Differential Revision: D78696006