Skip to content

Executorch Wasm Internal Build #14015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Executorch Wasm Internal Build #14015

wants to merge 1 commit into from

Conversation

Conarnar
Copy link
Contributor

@Conarnar Conarnar commented Sep 5, 2025

Summary:
Added internal build scripts for Executorch Wasm and unit tests.

Due to some intricacies the following things were done:

  • Emscripten build options don't work properly on fbcode, so only xplat targets were made.
  • Export scripts are only supported on fbcode, but do not work properly with the Emscripten build mode. Because of this, the test models for unit testing need to be built separately and copied into xplat.
  • Jest is configured to not search for unit tests within buck-out, so they must also be copied into xplat.
  • These are handled by xplat_build.sh, which can be run with yarn build. These files can also be deleted with yarn clean.
  • Unit tests won't build without test_models directory so dummy file is necessary to pass build rule CI.

Differential Revision: D81276482

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Sep 5, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14015

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures

As of commit ef31409 with merge base 41c299f (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 5, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D81276482

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 5, 2025

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@Conarnar @facebook-github-bot
Executorch Wasm Internal Build (pytorch#14015)
ef31409 
Summary:

Added internal build scripts for Executorch Wasm and unit tests.

Due to some intricacies the following things were done:
- Emscripten build options don't work properly on `fbcode`, so only `xplat` targets were made.
- Export scripts are only supported on `fbcode`, but do not work properly with the Emscripten build mode. Because of this, the test models for unit testing need to be built separately and copied into `xplat`.
- Jest is configured to not search for unit tests within `buck-out`, so they must also be copied into `xplat`.
- These are handled by `xplat_build.sh`, which can be run with `yarn build`. These files can also be deleted with `yarn clean`.
- Unit tests won't build without `test_models` directory so dummy file is necessary to pass build rule CI.

Reviewed By: lucylq

Differential Revision: D81276482
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D81276482

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucylq lucylq lucylq approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Conarnar @facebook-github-bot @lucylq