Update channels last python reference to not use memory_format=channels_last #14035

DrJessop · 2025-09-06T05:02:36Z

Summary: The default overload of custom channels last assumes that inputs and weights are permuted and contiguous in memory.

Differential Revision: D81842686

pytorch-bot · 2025-09-06T05:02:40Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14035

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 38 Pending, 5 Unrelated Failures

As of commit 8a1875e with merge base c3b842f ():

NEW FAILURE - The following job has failed:

pull / unittest-arm-backend-with-no-fvp (test_pytest_models) / linux-job (gh)
backends/arm/test/models/stable_diffusion/test_vae_AutoencoderKL.py::TestAutoencoderKL::test_AutoencoderKL_tosa_FP

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

pull / test-binary-size-linux-gcc / linux-job (gh) (similar failure)
##[error]The operation was canceled.
pull / test-openvino-linux / linux-job (gh) (similar failure)
##[error]The operation was canceled.
pull / test-setup-linux-gcc / linux-job (gh) (similar failure)
##[error]The operation was canceled.

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

pull / test-moshi-linux / linux-job (gh) (trunk failure)
##[error]The operation was canceled.
pull / test-samsung-models-linux / linux-job (gh) (trunk failure)
##[error]The operation was canceled.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

facebook-github-bot · 2025-09-06T05:02:46Z

This pull request was exported from Phabricator. Differential Revision: D81842686

…ls_last (pytorch#14035) Summary: The default overload of custom channels last assumes that inputs and weights are permuted and contiguous in memory. Differential Revision: D81842686

github-actions · 2025-09-06T05:08:17Z

This PR needs a `release notes:` label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

…ls_last (pytorch#14035) Summary: The default overload of custom channels last assumes that inputs and weights are permuted and contiguous in memory. Differential Revision: D81842686

facebook-github-bot · 2025-09-08T17:02:25Z

This pull request was exported from Phabricator. Differential Revision: D81842686

…ls_last (pytorch#14035) Summary: Pull Request resolved: pytorch#14035 The default overload of custom channels last assumes that inputs and weights are permuted and contiguous in memory. Differential Revision: D81842686

…ls_last (pytorch#14035) Summary: The default overload of custom channels last assumes that inputs and weights are permuted and contiguous in memory. Differential Revision: D81842686

facebook-github-bot · 2025-09-09T16:39:44Z

This pull request was exported from Phabricator. Differential Revision: D81842686

…ls_last (pytorch#14035) Summary: Pull Request resolved: pytorch#14035 The default overload of custom channels last assumes that inputs and weights are permuted and contiguous in memory. Differential Revision: D81842686

…ls_last (pytorch#14035) Summary: The default overload of custom channels last assumes that inputs and weights are permuted and contiguous in memory. Differential Revision: D81842686

facebook-github-bot · 2025-09-09T21:43:44Z

This pull request was exported from Phabricator. Differential Revision: D81842686

…ls_last (pytorch#14035) Summary: Pull Request resolved: pytorch#14035 The default overload of custom channels last assumes that inputs and weights are permuted and contiguous in memory. Differential Revision: D81842686

…ls_last (pytorch#14035) Summary: The default overload of custom channels last assumes that inputs and weights are permuted and contiguous in memory. Differential Revision: D81842686

facebook-github-bot · 2025-09-10T04:45:22Z

This pull request was exported from Phabricator. Differential Revision: D81842686

…ls_last (pytorch#14035) Summary: Pull Request resolved: pytorch#14035 The default overload of custom channels last assumes that inputs and weights are permuted and contiguous in memory. Differential Revision: D81842686

…ls_last (pytorch#14035) Summary: Our implementation is actually supposed to assume input shapes come in channels last, not relying on torch channels last memory format. Same thing with output shapes. Differential Revision: D81842686

facebook-github-bot · 2025-09-10T17:40:43Z

This pull request was exported from Phabricator. Differential Revision: D81842686

…ls_last (pytorch#14035) Summary: Our implementation is actually supposed to assume input shapes come in channels last, not relying on torch channels last memory format. Same thing with output shapes. Differential Revision: D81842686

…ls_last (pytorch#14035) Summary: Pull Request resolved: pytorch#14035 Our implementation is actually supposed to assume input shapes come in channels last, not relying on torch channels last memory format. Same thing with output shapes. Differential Revision: D81842686

meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 6, 2025

facebook-github-bot added the fb-exported label Sep 6, 2025

DrJessop force-pushed the export-D81842686 branch from 434d54a to 21c59c6 Compare September 8, 2025 17:02

DrJessop force-pushed the export-D81842686 branch from 21c59c6 to 7c4efe2 Compare September 9, 2025 16:33

DrJessop force-pushed the export-D81842686 branch from 7c4efe2 to 2956f93 Compare September 9, 2025 16:39

DrJessop force-pushed the export-D81842686 branch from 2956f93 to 1e2a0d1 Compare September 9, 2025 21:40

DrJessop force-pushed the export-D81842686 branch from 1e2a0d1 to 538169e Compare September 9, 2025 21:43

DrJessop force-pushed the export-D81842686 branch from 538169e to 823bb90 Compare September 10, 2025 04:42

DrJessop force-pushed the export-D81842686 branch from 823bb90 to e1de305 Compare September 10, 2025 04:45

DrJessop force-pushed the export-D81842686 branch from e1de305 to 8a1875e Compare September 10, 2025 17:40

hsharma35 approved these changes Sep 10, 2025

View reviewed changes

facebook-github-bot merged commit 517d7b5 into pytorch:main Sep 10, 2025
235 of 279 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Update channels last python reference to not use memory_format=channels_last #14035

Update channels last python reference to not use memory_format=channels_last #14035

DrJessop commented Sep 6, 2025

Uh oh!

pytorch-bot bot commented Sep 6, 2025 •

edited

Loading

Uh oh!

facebook-github-bot commented Sep 6, 2025

Uh oh!

github-actions bot commented Sep 6, 2025

Uh oh!

facebook-github-bot commented Sep 8, 2025

Uh oh!

facebook-github-bot commented Sep 9, 2025

Uh oh!

facebook-github-bot commented Sep 9, 2025

Uh oh!

facebook-github-bot commented Sep 10, 2025

Uh oh!

facebook-github-bot commented Sep 10, 2025

Uh oh!

Uh oh!

Uh oh!

Update channels last python reference to not use memory_format=channels_last #14035

Update channels last python reference to not use memory_format=channels_last #14035

Conversation

DrJessop commented Sep 6, 2025

Uh oh!

pytorch-bot bot commented Sep 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14035

❌ 1 New Failure, 38 Pending, 5 Unrelated Failures

Uh oh!

facebook-github-bot commented Sep 6, 2025

Uh oh!

github-actions bot commented Sep 6, 2025

This PR needs a release notes: label

Uh oh!

facebook-github-bot commented Sep 8, 2025

Uh oh!

facebook-github-bot commented Sep 9, 2025

Uh oh!

facebook-github-bot commented Sep 9, 2025

Uh oh!

facebook-github-bot commented Sep 10, 2025

Uh oh!

facebook-github-bot commented Sep 10, 2025

Uh oh!

Uh oh!

Uh oh!

pytorch-bot bot commented Sep 6, 2025 •

edited

Loading

This PR needs a `release notes:` label