Skip to content

Conversation

@martinlsm
Copy link
Collaborator

@martinlsm martinlsm commented Oct 24, 2025

The pass RetraceFoldedDtypesPass carries out extra processing after the output of FoldAndAnnotateQParamsPass, meaning that they are tightly coupled and always run in sequence.

Merge these two passes together into FoldAndAnnotateQParamsPass.

Test plan

No behavior is modified. Tests already in place are sufficient.

cc @freddan80 @per @zingo @oscarandersson8218 @digantdesai

…sPass

The pass RetraceFoldedDtypesPass carries out extra processing after the
output of FoldAndAnnotateQParamsPass, meaning that they are tightly
coupled and always run in sequence.

Merge these two passes together into FoldAndAnnotateQParamsPass.

Signed-off-by: Martin Lindström <[email protected]>
Change-Id: I1e68a4b87cef2778623fbac6a68a62abf5764abb
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 24, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15377

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 1 Cancelled Job, 3 Unrelated Failures

As of commit 7dd0f11 with merge base 7ce78c0 (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOB - The following job was cancelled. Please retry:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 24, 2025
@martinlsm
Copy link
Collaborator Author

@pytorchbot label ciflow/trunk

@martinlsm
Copy link
Collaborator Author

@pytorchbot label "partner: arm"

@pytorch-bot pytorch-bot bot added the partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm label Oct 24, 2025
@github-actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@martinlsm
Copy link
Collaborator Author

Failures look unrelated

Copy link
Collaborator

@Sebastian-Larsson Sebastian-Larsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated CI failures

@Sebastian-Larsson Sebastian-Larsson merged commit 4675292 into pytorch:main Oct 27, 2025
435 of 444 checks passed
GregoryComer added a commit to GregoryComer/executorch that referenced this pull request Oct 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants