Skip to content

Conversation

@Erik-Lundell
Copy link
Collaborator

@Erik-Lundell Erik-Lundell commented Oct 24, 2025

When sum is called without arguments,
it is traced as sum.default rather than sum.dim_IntList, which 1) is lowered to edge with dims=[] instead of None, and 2) is not annotated in the quantizer.

This commit fixes those issues and adds tests.

cc @freddan80 @per @zingo @oscarandersson8218 @digantdesai

When sum is called without arguments,
it is traced as sum.default rather than sum.dim_IntList,
which 1) is lowered to edge with dims=[] instead of None,
and 2) is not annotated in the quantizer.

This commit fixes those issues and adds tests.

Signed-off-by: Erik Lundell <[email protected]>
Change-Id: Ic9ae84c62a713f136de7bff2594bacbdfc759995
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 24, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15380

Note: Links to docs will display an error until the docs builds have been completed.

❌ 8 New Failures, 2 Cancelled Jobs, 3 Unrelated Failures

As of commit fd928a6 with merge base de56c81 (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOBS - The following jobs were cancelled. Please retry:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 24, 2025
@Erik-Lundell Erik-Lundell added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk release notes: none Do not include this in the release notes labels Oct 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: none Do not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant