-
Notifications
You must be signed in to change notification settings - Fork 759
[WIP] Add option to build with all xnnpack, vulkan, qnn #16189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16189
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 1 New FailureAs of commit 8dd4648 with merge base ee236cb ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
Hi @Copilot! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
This PR needs a
|
|
@copilot Can you show me the diff? I can upload patch |
Here's the diff for the changes (commit 3623f35): diff --git a/.github/workflows/android-release-artifacts.yml b/.github/workflows/android-release-artifacts.yml
index beda0f7..c02c164 100644
--- a/.github/workflows/android-release-artifacts.yml
+++ b/.github/workflows/android-release-artifacts.yml
@@ -17,6 +17,7 @@ on:
- "xnnpack"
- "vulkan"
- "qnn"
+ - "all"
schedule:
- cron: 0 10 * * *
@@ -94,14 +95,14 @@ jobs:
GRADLE_ARGS+=" -Dflavor=${FLAVOR}"
fi
- if [[ "$FLAVOR" == "vulkan" || -z "$FLAVOR" ]]; then
+ if [[ "$FLAVOR" == "vulkan" || "$FLAVOR" == "all" || -z "$FLAVOR" ]]; then
curl -O https://sdk.lunarg.com/sdk/download/1.4.321.1/linux/vulkansdk-linux-x86_64-1.4.321.1.tar.xz
tar xf vulkansdk-linux-x86_64-1.4.321.1.tar.xz -C /tmp
export PATH="/tmp/1.4.321.1/x86_64/bin:$PATH"
export EXECUTORCH_BUILD_VULKAN=ON
fi
- if [[ "$FLAVOR" == "qnn" ]]; then
+ if [[ "$FLAVOR" == "qnn" || "$FLAVOR" == "all" ]]; then
PYTHON_EXECUTABLE=python bash .ci/scripts/setup-qnn-deps.sh
PYTHON_EXECUTABLE=python bash .ci/scripts/build-qnn-sdk.sh
export EXECUTORCH_BUILD_QNN=ONThe patch file is available at |
Plan to add "all" flavor option to android-release-artifacts.yml
Changes Summary:
"$FLAVOR" == "all""$FLAVOR" == "all"When "all" is selected, the workflow will build with all three backends: xnnpack (default), vulkan, and qnn.
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.
cc @SS-JIA @manuelcandales @digantdesai @cbilgin