Skip to content

Update ScalarToTensorPass to correctly track the modified bit #16231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
DrJessop wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Update ScalarToTensorPass to correctly track the modified bit #16231

DrJessop wants to merge 3 commits into from
+618 −345

Conversation

@DrJessop
Copy link
Contributor

@DrJessop DrJessop commented Dec 12, 2025

Summary: Update ScalarToTensorPass to correctly track the modified bit, only run export pass if there are changes to the graph.

Differential Revision: D89085647

Andrew Grebenisan added 3 commits December 12, 2025 14:11
@facebook-github-bot
Update more passes to use new pass interface/correctly set their modi…
303ae00 
…fied bits (pytorch#16228)

Summary:

Update
- SinkOpsCloserToUsePass
- HoistOpsCloserToDefPass
- PostponePermuteOpBelowSqueezeOrUnsqueezeLikeView
- SimplifySliceOpPass
- BindOptionalArgsPass
- ReplaceConstantPadWithTuringExtendPass

to either use new pass interface (which is more efficient/correctly sets modified bit) or just correctly set modified bit if doesn't fit the interface well.

Differential Revision: D87898571
@facebook-github-bot
Update AdvanceQuantizeOpAboveDefChainPass, PostponeDequantizeOpBelowU…
13ab707 
…seChainPass, and ScalarToTensorPass to correctly set modified bit (pytorch#16230)

Summary:

Update 
- AdvanceQuantizeOpAboveDefChainPass
- PostponeDequantizeOpBelowUseChainPass

to correctly track modified bit and updated tests to check for numerical correctness.

Differential Revision: D87900822
@facebook-github-bot
Update ScalarToTensorPass to correctly track the modified bit
2317f5b 
Summary: Update ScalarToTensorPass to correctly track the modified bit, only run export pass if there are changes to the graph.

Differential Revision: D89085647
@pytorch-bot
Copy link

pytorch-bot bot commented Dec 12, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16231

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 2 New Failures, 1 Cancelled Job, 4 Unrelated Failures

As of commit 2317f5b with merge base c493e2d (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOB - The following job was cancelled. Please retry:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 12, 2025
@meta-codesync
Copy link

meta-codesync bot commented Dec 12, 2025

@DrJessop has exported this pull request. If you are a Meta employee, you can view the originating Diff in D89085647.

@github-actions
Copy link

github-actions bot commented Dec 12, 2025

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

JacobSzwejbka
JacobSzwejbka reviewed Dec 12, 2025
View reviewed changes
exir/passes/scalar_to_tensor_pass.py

if changed:
graph_module.recompile()
return super().call(graph_module)
Copy link
Contributor

@JacobSzwejbka JacobSzwejbka Dec 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why bother calling super anymore? Wont this just walk the graph doing a bunch of nothing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JacobSzwejbka JacobSzwejbka JacobSzwejbka left review comments

@larryliu0820 larryliu0820 Awaiting requested review from larryliu0820 larryliu0820 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@DrJessop @JacobSzwejbka