Add in_progress() state check to Method::execute() #16531
Draft
+122
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds in_progress() to detect when execution is mid-way through the instruction sequence. Method::execute() now returns InvalidState if called while in_progress() is true. execute() auto-resets step_state_ on error to allow retry attempts. step() does not auto-reset (requires manual reset_execution() call). Tests verify initial state, mid-execution detection, error recovery, and interaction between execute() and step() APIs.
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16531
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 1 Unrelated FailureAs of commit 23140be with merge base 7fa1aaa ( UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
This PR needs a
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds in_progress() to detect when execution is mid-way through the instruction sequence. Method::execute() now returns InvalidState if called while in_progress() is true.
execute() auto-resets step_state_ on error to allow retry attempts. step() does not auto-reset (requires manual reset_execution() call).
Test plan