[borys3kk]

Summary

Backend passes keep a reference to the ExportedProgram they were built from (XNNPACKPass.exported_program, for one), while ExportedProgramPassManager runs them on a shallow copy of it and rebuilds that copy's signature afterwards. delete_constant_placeholder replaced the original program's signature object, so the copy kept the old one, still listing the deleted placeholder, and its verifier failed with:

torch._export.verifier.SpecViolationError: Parameter <name> is not in the state dict.

create_constant_placeholder already inserts into the shared input_specs list in place; deletion now removes from that list in place too.

Test plan

New tests in backends/transforms/test/test_create_delete_constant_placeholder.py delete a placeholder from inside a pass run through ExportedProgramPassManager, one per kind: parameter, persistent buffer, non-persistent buffer and lifted constant tensor.

python -m pytest backends/transforms/test/test_create_delete_constant_placeholder.py

Without the fix, the 4 new tests fail (SpecViolationError for parameter, buffer and constant tensor, KeyError for the non-persistent buffer) and the 6 existing ones pass. With the fix, all 10 pass.

python -m pytest -n auto backends/transforms/test
python -m pytest backends/xnnpack/test/passes/test_batch_norm_fusion.py

325 passed, 50 skipped, 1 xfailed; and 5 passed. I could not run the Arm pass tests that call delete_constant_placeholder because they need tosa_serializer.

cc @GregoryComer @digantdesai @cbilgin @JakeStevens @cccclai @nil-is-all @rascani @msluszniak

[pytorch-bot]

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/24111

• 📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 Unclassified Failures

As of commit 6789b71 with merge base 422cc39 ():

UNCLASSIFIED FAILURES - DrCI could not classify the following jobs because the workflow did not run on the merge base. The failures may be pre-existing on trunk or introduced by this PR:

• periodic / gather-models (gh) (this job did not run on the merge base, so DrCI cannot tell whether the failure is pre-existing)
• periodic / Resolve CI docker image / resolve (gh) (this job did not run on the merge base, so DrCI cannot tell whether the failure is pre-existing)

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[github-actions]

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.