[ROCm] Support building PyTorch with GLOO on Windows #461
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jammm
changed the title
10 tasks
ScottTodd
approved these changes
Aug 11, 2025
|
@jammm sorry if I’m being impatient, but since this PR was approved, could it be merged? |
It's not up to me to merge this unfortunately. The gloo maintainers need to merge it. It's my first PR here actually, so not sure of the exact flow. |
Oh, I didn’t know that. Np, then we’ll wait for them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helps fix imports for
transformerslib which seems to import torch.distributed. ROCm/TheRock#1202It may or may not help in proper WIndows support for torch.distributed (since RCCL isn't on Windows atm), but it does let us build pytorch w/ USE_DISTRIBUTED=ON, which helps fix import errors like the above, so users on their single GPU systems can run comfyui without facing import errors.
Tested on Windows w/ PyTorch main branch via. TheRock.