Catch exception from shm connection start() #135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: util::ringbuffer::shm::create(kDefaultSize) could throw system exception and cause connection destruction before initilization completes. If not catch the exception on connection level, destruction will clean up unregistered resources to cause unrelated errors. Differential Revision: D20616906 fbshipit-source-id: 3b91458e26cca2e6bd393264ad1ca6dea4fb7b29
|
This pull request was exported from Phabricator. Differential Revision: D20616906 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
util::ringbuffer::shm::create(kDefaultSize) could throw system exception and
cause connection destruction before initilization completes. If not catch the
exception on connection level, destruction will clean up unregistered
resources to cause unrelated errors.
Differential Revision: D20616906