Make Nova build job timeout parameter configurable #5631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
facebook-github-bot
added
the
CLA Signed
malfet
approved these changes
Sep 9, 2024
spcyppt
added a commit
to spcyppt/FBGEMM
that referenced
this pull request
Sep 10, 2024
Summary: FBGEMM build for cuda 12.1 on Nova has been facing time-out error and unable to release 12.1 binaries since it takes longer than 120 minutes. For example, https://github.com/pytorch/FBGEMM/actions/runs/10772363019/job/29869849673. Huy from Dev infra has helped make time-out as a configurable parameter pytorch/test-infra#5631. This diff extends time out to 180 mins until we find a good solution to reduce build time. Differential Revision: D62415584
facebook-github-bot
pushed a commit
to pytorch/FBGEMM
that referenced
this pull request
Sep 10, 2024
Summary: Pull Request resolved: #3102 FBGEMM build for cuda 12.1 on Nova has been facing time-out error and unable to release 12.1 binaries since it takes longer than 120 minutes. For example, https://github.com/pytorch/FBGEMM/actions/runs/10772363019/job/29869849673. Huy from Dev infra has helped make time-out as a configurable parameter pytorch/test-infra#5631. This diff extends time out to 180 mins until we find a good solution to reduce build time. Reviewed By: sryap Differential Revision: D62415584 fbshipit-source-id: 3bdbd0beb609797ab87ebaaf2227789545983af3
This was referenced Sep 11, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TSIA. This is a request from fbgemm in which their Linux CUDA build jobs is too close to the 120 minutes threshold and frequently timeout, i.e. https://github.com/pytorch/FBGEMM/actions/runs/10772363019/job/29869849673