Adjust index page Cache-Control headers
#6188
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@edmorley is attempting to deploy a commit to the Meta Open Source Team on Vercel. A member of the Team first needs to authorize it. |
facebook-github-bot
added
the
CLA Signed
atalman
reviewed
Jan 20, 2025
atalman
reviewed
Jan 20, 2025
atalman
reviewed
Jan 20, 2025
|
Hi @edmorley Looks good. lets also keep explicit |
edmorley
force-pushed
the
index-cache-control
branch
from
222a002 to
59d6334
Compare
|
@atalman Thank you for the initial review. I've made the suggested changes and rebased on latest |
edmorley
force-pushed
the
index-cache-control
branch
from
59d6334 to
2fc07fe
Compare
|
@atalman Hi! I don't suppose you have time for a re-review? :-) |
This changes the `Cache-Control` value for index pages from: `no-cache,no-store,must-revalidate` ...to: `max-age=600, public` In order to allow the pages to be cached for up to 10 minutes. The new value was chosen so that it matches that returned for PyPI index pages: ``` $ curl -sSI https://pypi.org/simple/ | rg cache-control cache-control: max-age=600, public ``` For explanations of the directives, see: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Cache-Control#response_directives Fixes #pytorch/pytorch#130571.
edmorley
force-pushed
the
index-cache-control
branch
from
2fc07fe to
9f7d1b0
Compare
|
@atalman Hi! Your review comments have been addressed (back in Feb), and I've just rebased again on I don't suppose you could re-review and merge? Thanks :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the
Cache-Controlvalue for index pages from:no-cache,no-store,must-revalidate...to:
max-age=600, publicIn order to allow the pages to be cached for up to 10 minutes.
The new value was chosen so that it matches that returned for PyPI index pages:
For explanations of the directives, see:
https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Cache-Control#response_directives
Fixes pytorch/pytorch#130571.