Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove visual studio 2019 install in test infra #6226

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Camyll
Copy link
Contributor

@Camyll Camyll commented Jan 28, 2025

Original Issue: pytorch/pytorch#128835
Follow up on PR: pytorch/pytorch#145319

Copy link

vercel bot commented Jan 28, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
torchci ⬜️ Ignored (Inspect) Jan 28, 2025 7:44pm

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 28, 2025
@Camyll Camyll marked this pull request as ready for review January 28, 2025 21:08
@Camyll Camyll assigned Camyll and huydhn and unassigned Camyll Jan 28, 2025
@huydhn
Copy link
Contributor

huydhn commented Jan 29, 2025

We need to do a bit of testing for this change after pytorch/pytorch#145863 lands. So the first step is to bake a new AMI https://github.com/pytorch/test-infra/tree/main/aws/ami/windows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants