Maxoutissue

[yangw-dev]

Add customized highlight option for BranchAndCommitPicker

Add customized highlight option for commit select
#6175

Details

• add filename as part of the query for Commit
• filter and highlight commits based on the selected key word.
• add info icon present highlight section's details

Other Options (can be future)

define a dropdown to filter multiple keys to highlight

Demo

Tooltip to indicate the highlight reason:

Gif for the action

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
torchci	✅ Ready (Inspect)	Visit Preview	Jan 29, 2025 0:23am

[huydhn]

Do you think we need a highlight dropdown list? We can highlight commit by default as it always provides more information than not highlighting anything. If the commit has more than one highlight items, both can be mentioned in the ⓘ icon?

[yangw-dev]

Do you think we need a highlight dropdown list? We can highlight commit by default as it always provides more information than not highlighting anything. If the commit has more than one highlight items, both can be mentioned in the ⓘ icon?

I think the highlight dropdown can be benefit in the future , for instance, if we introduce multiple hightlight options, user can filter it based on their own needs instead of hardcode by us, this gives flexibility to users to choose the info they want, like I mentioned in other options section with multiple key words. but I can def just get ride of it right now.

[huydhn]

I think the highlight dropdown can be benefit in the future , for instance, if we introduce multiple hightlight options, user can filter it based on their own needs instead of hardcode by us, this gives flexibility to users to choose the info they want, like I mentioned in other options section with multiple key words. but I can def just get ride of it right now.

Got it. We can keep it then. In that case, I think we should move the box all the way to the left, next to the time range. There is this request from AMD for cross-device comparison #6221, so I think we might need to have 2 device dropdown lists for base and new commits.