[Utilization] Setup API and UI Inital page #6240
Open
+742
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
torchci/pages/utilization/[workflowId]/[jobId]/[attempt]/[[...page]].tsx
Fixed
Show fixed
Hide fixed
clee2000
reviewed
Jan 31, 2025
torchci/pages/utilization/[workflowId]/[jobId]/[attempt]/[[...page]].tsx
Outdated
Show resolved
Hide resolved
clee2000
reviewed
Jan 31, 2025
clee2000
reviewed
Jan 31, 2025
clee2000
reviewed
Jan 31, 2025
| if (checkType(obj) == "array") { | ||
| for (let idx = 0; idx < obj.length; idx++) { | ||
| const nextObj = obj[idx]; | ||
| let next_path = formPath(path, `{idx}`); |
There was a problem hiding this comment.
I think
Suggested change
| let next_path = formPath(path, `{idx}`); | |
| let next_path = formPath(path, `${idx}`); |
clee2000
reviewed
Jan 31, 2025
| } | ||
|
|
||
| if (!data) { | ||
| return <div>loading...</div>; |
There was a problem hiding this comment.
iirc you made a loading component, do you want to use that here?
There was a problem hiding this comment.
yah this just a place holder will update later!
clee2000
reviewed
Jan 31, 2025
| created_at: string; | ||
| workflow_name: string; | ||
| job_name: string; | ||
| segments: any[]; |
There was a problem hiding this comment.
Is this supposed to be Segments[]?
clee2000
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Setup API and UI for utilization time series.
Currently hooked with clickhouse fortesting tables to unblock UI development while waiting for the datapipline code merged.
working api: https://torchci-git-utiltest-fbopensource.vercel.app/api/utilization/12937937547/36088234580/1
working UI rendering: https://torchci-git-utiltest-fbopensource.vercel.app/utilization/12937937547/36088234580/1
##Details