get rid of unncessary fx wrap in regrouping #2882
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D72884977 |
ZhengkaiZ
force-pushed
the
export-D72884977
branch
from
4c5a34c to
926e2bd
Compare
ZhengkaiZ
added a commit
to ZhengkaiZ/torchrec
that referenced
this pull request
Apr 14, 2025
Summary: [torchrec] get rid of unncessary fx wrap in regrouping Reviewed By: taylorKempWork, FulinHuang Differential Revision: D72884977
ZhengkaiZ
added a commit
to ZhengkaiZ/torchrec
that referenced
this pull request
Apr 14, 2025
Summary: [torchrec] get rid of unncessary fx wrap in regrouping Reviewed By: taylorKempWork, FulinHuang Differential Revision: D72884977
ZhengkaiZ
force-pushed
the
export-D72884977
branch
from
926e2bd to
7ce569c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D72884977 |
ZhengkaiZ
added a commit
to ZhengkaiZ/torchrec
that referenced
this pull request
Apr 14, 2025
Summary: [torchrec] get rid of unncessary fx wrap in regrouping Reviewed By: taylorKempWork, FulinHuang Differential Revision: D72884977
ZhengkaiZ
force-pushed
the
export-D72884977
branch
from
7ce569c to
d0861b2
Compare
|
This pull request was exported from Phabricator. Differential Revision: D72884977 |
cp2923
approved these changes
Apr 14, 2025
Yes, existing test case already covered it |
jingsh
approved these changes
Apr 14, 2025
|
This pull request was exported from Phabricator. Differential Revision: D72884977 |
ZhengkaiZ
added a commit
to ZhengkaiZ/torchrec
that referenced
this pull request
Apr 14, 2025
Summary: Pull Request resolved: pytorch#2882 [torchrec] get rid of unncessary fx wrap in regrouping Reviewed By: jingsh, taylorKempWork, FulinHuang Differential Revision: D72884977
ZhengkaiZ
force-pushed
the
export-D72884977
branch
from
d0861b2 to
56df928
Compare
ZhengkaiZ
added a commit
to ZhengkaiZ/torchrec
that referenced
this pull request
Apr 15, 2025
Summary: [torchrec] get rid of unncessary fx wrap in regrouping Reviewed By: jingsh, taylorKempWork, FulinHuang Differential Revision: D72884977
ZhengkaiZ
force-pushed
the
export-D72884977
branch
from
56df928 to
2478661
Compare
|
This pull request was exported from Phabricator. Differential Revision: D72884977 |
Summary: [torchrec] get rid of unncessary fx wrap in regrouping Reviewed By: jingsh, taylorKempWork, FulinHuang Differential Revision: D72884977
ZhengkaiZ
force-pushed
the
export-D72884977
branch
from
2478661 to
492e0ba
Compare
|
This pull request was exported from Phabricator. Differential Revision: D72884977 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: [torchrec] get rid of unncessary fx wrap in regrouping
Differential Revision: D72884977