-
Notifications
You must be signed in to change notification settings - Fork 343
[WIP][Kernels] Contiguous Group GeMM #1036
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lessw2020
wants to merge
26
commits into
main
Choose a base branch
from
lessw2020/contiguous_groupGeMM
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdnanHoque
reviewed
Apr 1, 2025
…file for both backward and forward to use.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is adds a 'contiguous' group gemm with dynamic input and dynamic expert support. This is similar in spirit to the DeepSeek GEMM contiguous where inputs must be aligned to a given dimensionality of group_size_m and padded if not meeting that alignment.
1 - Forward and Backward are all working. See cg_forward.py and cg_backward.py:
Forward:
2 - demo.py and full_moe_e2e put all the pieces together for an implementation.
3 - cg_reference.py has the Pytorch reference equivalence.
Usage:
It is important to note that input tokens must be one expert per block, where block is defined as group_size_m. No mixing of experts within a block is allowed.