Skip to content

Enable save plan caching #1140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Enable save plan caching #1140

wants to merge 1 commit into from
+2 −1

Conversation

MeetVadakkanchery
Copy link

Differential Revision: D73514829

@MeetVadakkanchery @facebook-github-bot
Enable save plan caching
5effd55 
Differential Revision: D73514829
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Apr 23, 2025
@facebook-github-bot
Copy link

This pull request was exported from Phabricator. Differential Revision: D73514829

fegin
fegin reviewed Apr 23, 2025
View reviewed changes
Copy link
Contributor

@fegin fegin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but the unittest failing and linter failure are real. And it is not very safe to do FBCode first for torchtitan as we didn't see automatically landing when landing the diff internally first. This may cause the history out-of-sync.

@MeetVadakkanchery
Copy link
Author

Cool, this is just a draft for now. I'll test with a few jobs as well after launching internally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fegin fegin fegin left review comments

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Meta Open Source bot. fb-exported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MeetVadakkanchery @facebook-github-bot @fegin