-
Notifications
You must be signed in to change notification settings - Fork 639
Fix command in config #2796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fix command in config #2796
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchtune/2796
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 7621aae with merge base 2344509 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hang on, why is this happening?
hmm, somehow override is not working properly |
It looks like you just need to put the task names as strings, no? |
Will try tomorrow, but maybe this is a real fix |
Beautiful CI |
@joecummings No it is not real fix or maybe I've misunderstood you, the command that I'm using (from config):
|
Context
What is the purpose of this PR? Is it to
Please link to any issues this PR addresses.
Changelog
What are the changes made in this PR?
zsh: no matches found: tasks=[truthfulqa_mc2,hellaswag]
Test plan
Please make sure to do each of the following if applicable to your PR. If you're unsure about any one of these just ask and we will happily help. We also have a contributing page for some guidance on contributing.
pre-commit install
)pytest tests
pytest tests -m integration_test
UX
If your function changed a public API, please add a dummy example of what the user experience will look like when calling it.
Here is a docstring example
and a tutorial example