Skip to content

Fix command in config #2796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

krammnic
Copy link
Contributor

@krammnic krammnic commented Jun 6, 2025

Context

What is the purpose of this PR? Is it to

  • add a new feature
  • fix a bug
  • update tests and/or documentation
  • other (please add here)

Please link to any issues this PR addresses.

Changelog

What are the changes made in this PR?

  • We need to remove tasks=[...]. In another case we get something like zsh: no matches found: tasks=[truthfulqa_mc2,hellaswag]

Test plan

Please make sure to do each of the following if applicable to your PR. If you're unsure about any one of these just ask and we will happily help. We also have a contributing page for some guidance on contributing.

  • run pre-commit hooks and linters (make sure you've first installed via pre-commit install)
  • add unit tests for any new functionality
  • update docstrings for any new or updated methods or classes
  • run unit tests via pytest tests
  • run recipe tests via pytest tests -m integration_test
  • manually run any new or modified recipes with sufficient proof of correctness
  • include relevant commands and any other artifacts in this summary (pastes of loss curves, eval results, etc.)

UX

If your function changed a public API, please add a dummy example of what the user experience will look like when calling it.
Here is a docstring example
and a tutorial example

  • I did not change any public API
  • I have added an example to docs or docstrings

Copy link

pytorch-bot bot commented Jun 6, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchtune/2796

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 7621aae with merge base 2344509 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 6, 2025
@krammnic krammnic changed the title Update eleuther_evaluation.yaml Fix command in config Jun 6, 2025
Copy link
Contributor

@joecummings joecummings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hang on, why is this happening?

@krammnic
Copy link
Contributor Author

krammnic commented Jun 6, 2025

hmm, somehow override is not working properly

@joecummings
Copy link
Contributor

hmm, somehow override is not working properly

It looks like you just need to put the task names as strings, no?

@krammnic
Copy link
Contributor Author

krammnic commented Jun 7, 2025

Will try tomorrow, but maybe this is a real fix

@krammnic
Copy link
Contributor Author

krammnic commented Jun 9, 2025

Beautiful CI

@krammnic
Copy link
Contributor Author

@joecummings No it is not real fix or maybe I've misunderstood you, the command that I'm using (from config):

tune run eleuther_eval --config eleuther_evaluation tasks=["truthfulqa_mc2","hellaswag"]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants