Skip to content

Add support for distributed checkpointing of HF safetensors with DCP #2851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

ankitageorge
Copy link
Contributor

@ankitageorge ankitageorge commented Jun 25, 2025

Context

What is the purpose of this PR? Is it to

  • add a new feature
  • fix a bug
  • update tests and/or documentation
  • other (please add here)

Please link to any issues this PR addresses.

Changelog

What are the changes made in this PR?

  • Currently when saving and loading HF safetensors with DCP, we're still doing rank zero consolidation and then saving it. With this change we can save checkpoints in a distributed fashion and do the consolidation in DCP's finish step, and by-pass the rank-zero checkpointing which is the current approach. This PR adds the ability to use this functionality. This finish step consolidation is currently slow, but working on speeding it up. The API call from torchtune shouldn't change.
  • Without the consolidation, on a 70B model that was taking 260s to save without DCP, is now taking 70s to save the sharded tensors.

Test plan

Please make sure to do each of the following if applicable to your PR. If you're unsure about any one of these just ask and we will happily help. We also have a contributing page for some guidance on contributing.

  • [x ] run pre-commit hooks and linters (make sure you've first installed via pre-commit install)
  • add unit tests for any new functionality
  • update docstrings for any new or updated methods or classes
  • [x ] run unit tests via pytest tests
  • [x ] run recipe tests via pytest tests -m integration_test
  • [ x] manually run any new or modified recipes with sufficient proof of correctness
  • include relevant commands and any other artifacts in this summary (pastes of loss curves, eval results, etc.)

UX

If your function changed a public API, please add a dummy example of what the user experience will look like when calling it.
Here is a docstring example
and a tutorial example

  • I did not change any public API
  • [x ] I have added an example to docs or docstrings

Copy link

pytorch-bot bot commented Jun 25, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchtune/2851

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit b215e3a with merge base 3d73591 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 25, 2025
@ankitageorge ankitageorge changed the title Dcp hf dist Add support for distributed checkpointing of HF safetensors with DCP Jun 25, 2025
@ankitageorge ankitageorge marked this pull request as ready for review June 25, 2025 16:03
@ankitageorge ankitageorge requested a review from joecummings June 25, 2025 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants