fix: add utility capability for local_docker (#906) #907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
@andywag has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@andywag has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
Thanks for checking @andywag. Do you happen to know why do we still need device_request capabilities for I mentioned an alternative solution in #906 to delete this section entirely (e.g. we don't have it for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nvidia Docker images require adding libraries like
libnvidia-mlthat are part ofutilitycapability.TorchX currently only adds
computehere.Add
utilitynext tocompute. Similar fixes here and hereNOTE: nvidia-container-runtime has been superseded by nvidia-container-toolkit.
Test plan:
☑ updated unit test
☑ verified works with
compute,utility☑ verfiied works with default device capabilities too