Skip to content

add aarch64 docker for torch and xla wheels #3666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

snadampal
Copy link
Contributor

@snadampal snadampal commented Jun 26, 2022

Updated the default Dockerfile and tested it on aarch64 with ubuntu:focal base image.
docker build -t --build-arg base_image=ubuntu:focal torch-xla -f docker/Dockerfile .

@snadampal
Copy link
Contributor Author

snadampal commented Jun 26, 2022

This PR depends on #3660

@snadampal
Copy link
Contributor Author

Looks like new docker file is not required for aarch64. I'm making the default Dockerfile to work, fixing the wheel builder script which gets invoked directly from the Dockerfile for the actual build.

Tested with base_image=ubuntu:focal
docker build -t --build-arg base_image=ubuntu:focal torch-xla -f docker/Dockerfile .
@snadampal snadampal force-pushed the torch_xla_docker_aarch64 branch from cf73639 to 002168d Compare September 30, 2022 16:23
@snadampal
Copy link
Contributor Author

Hi @JackCaoG , I've updated the default Dockerfile and tested it on aarch64 with ubuntu:focal base image.
docker build -t --build-arg base_image=ubuntu:focal torch-xla -f docker/Dockerfile .

@snadampal
Copy link
Contributor Author

Hi @JackCaoG, @will-cromar , please let me know if there is any feedback on this.

Comment on lines +20 to +21
RUN echo 'debconf debconf/frontend select Noninteractive' | debconf-set-selections
RUN sudo apt-get install -y -q
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you elaborate a bit on what this line is trying to do?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was getting debian front end config issues, it was going into interactive mode and expecting user response.
I see you aleady have this for the wheel script (https://github.com/pytorch/xla/blob/master/scripts/build_torch_wheels.sh#L9) , but still it was going to interactive mode

DEBIAN_FRONTEND=noninteractive

When I looked around, this is where I found the above solution
moby/moby#27988 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants