-
Notifications
You must be signed in to change notification settings - Fork 545
add aarch64 docker for torch and xla wheels #3666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
This PR depends on #3660 |
2228b37
to
cf73639
Compare
Looks like new docker file is not required for aarch64. I'm making the default Dockerfile to work, fixing the wheel builder script which gets invoked directly from the Dockerfile for the actual build. |
Tested with base_image=ubuntu:focal docker build -t --build-arg base_image=ubuntu:focal torch-xla -f docker/Dockerfile .
cf73639
to
002168d
Compare
Hi @JackCaoG , I've updated the default Dockerfile and tested it on aarch64 with ubuntu:focal base image. |
Hi @JackCaoG, @will-cromar , please let me know if there is any feedback on this. |
RUN echo 'debconf debconf/frontend select Noninteractive' | debconf-set-selections | ||
RUN sudo apt-get install -y -q |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you elaborate a bit on what this line is trying to do?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was getting debian front end config issues, it was going into interactive mode and expecting user response.
I see you aleady have this for the wheel script (https://github.com/pytorch/xla/blob/master/scripts/build_torch_wheels.sh#L9) , but still it was going to interactive mode
DEBIAN_FRONTEND=noninteractive
When I looked around, this is where I found the above solution
moby/moby#27988 (comment)
Updated the default Dockerfile and tested it on aarch64 with ubuntu:focal base image.
docker build -t --build-arg base_image=ubuntu:focal torch-xla -f docker/Dockerfile .