Skip to content

Conversation

aws-yyjau
Copy link
Contributor

@aws-yyjau aws-yyjau commented May 28, 2025

Notes

  1. Following up on test: add test_xla_graph_execution to test flags (_set_allow_execution with PT_XLA_DEBUG_LEVEL) #9171, we'd like to update the documentation so that this feature can be properly used by neuron (and other XLA) customers.

@aws-yyjau
Copy link
Contributor Author

aws-yyjau commented May 29, 2025

Hi @mikegre-google ,

I updated the docs based on your comments. Let me know if it looks good. Thanks for your review!

@aws-yyjau
Copy link
Contributor Author

Hi @tengyifei

Thanks for your comments! I updated the doc based on that. Please let me know if that addresses your comments.

@tengyifei tengyifei enabled auto-merge (squash) June 2, 2025 02:48
@qihqi qihqi requested a review from mikegre-google June 2, 2025 03:31
auto-merge was automatically disabled June 2, 2025 18:40

Head branch was pushed to by a user without write access

@qihqi qihqi requested a review from mikegre-google June 3, 2025 03:05
@aws-yyjau
Copy link
Contributor Author

Hi @mikegre-google

Let me know if you have more comments. Thanks!

@qihqi qihqi enabled auto-merge (squash) June 10, 2025 04:19
@aws-yyjau
Copy link
Contributor Author

Hi @mikegre-google

Checking in, any comments from you? Thanks!

Copy link
Collaborator

@mikegre-google mikegre-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the ping. Looks good!

@aws-yyjau
Copy link
Contributor Author

Hi @mikegre-google
Thank you for reviewing the PR in details and giving great suggestions!
Would be great if you could help merge and close the item.

@tengyifei tengyifei disabled auto-merge June 11, 2025 23:33
@tengyifei tengyifei merged commit 3bc9ece into pytorch:master Jun 11, 2025
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants