Skip to content

Make RioDataset public API #115

Description

@gerritholl

Feature Request

Is your feature request related to a problem? Please describe.

The RioDataset class is defined in the module _xrimage_rasterio. The leading underscore suggests this is considered private API. In trollimage, I want to test whether a dataset is a RioDataset (for rationale, see pytroll/trollflow2#168). A way way to do that would be with isinstance(x, RioDataset), but this requires importing from a private module.

Describe the solution you'd like

I would like that RioDataset is publicly exposed.

Describe any changes to existing user workflow

N/A, I think.

Additional context

I could do type testing based on the name. This would eliminate the need to import the class. That's not very Pythonic.

I could rely on duck-typing and EAFP. Considering the potential diversity of types returned from satpys Scene.save_datasets, I'm not sure if that's a good idea.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions