Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PyCon KR 2023 videos #1207

Merged
merged 2 commits into from
Dec 17, 2024
Merged

Add PyCon KR 2023 videos #1207

merged 2 commits into from
Dec 17, 2024

Conversation

jungmir
Copy link
Contributor

@jungmir jungmir commented Dec 14, 2024

Add PyCon KR 2023 videos.

HelloPy members are updating PyConKR 2023 Videos.

@jonafato
Copy link
Member

Thank you! A couple of requests:

  • Can you remove the conference name and speaker names from talk titles? PyVideo has dedicated fields for conference name and speaker name, and this change will make talk titles on pyvideo.org match the titles used on the conference's official talk list at https://2023.pycon.kr/session.
  • Can you update the JSON file names to be lower-case and replace with -? My usual tool for this task is python-slugify to generate the filename with slugify.slugify(talk_title) + ".json".

@jungmir
Copy link
Contributor Author

jungmir commented Dec 15, 2024

Thanks for the feedback, I've included everything you requested for.

@jonafato
Copy link
Member

Thank you for the updates! I'm going to push a couple of minor changes to your branch to improve the rendering on the site and then merge this PR.

@jonafato jonafato mentioned this pull request Dec 17, 2024
@jonafato jonafato merged commit c50712c into pyvideo:main Dec 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants