Skip to content

Conversation

@user27182
Copy link
Contributor

This feature was implemented as part of #211 for the unit tests. This PR adds this same feature to the doc mode tests.

@github-actions github-actions bot added the enhancement New feature or request label Sep 4, 2025
@codecov-commenter
Copy link

codecov-commenter commented Sep 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.04%. Comparing base (ea3bfac) to head (e54cc22).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #213      +/-   ##
==========================================
+ Coverage   97.98%   98.04%   +0.05%     
==========================================
  Files           3        3              
  Lines         597      614      +17     
  Branches       77       77              
==========================================
+ Hits          585      602      +17     
  Misses          5        5              
  Partials        7        7              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@user27182
Copy link
Contributor Author

user27182 commented Sep 9, 2025

New doc mode tests were added in b2a252d. This caused tests unrelated to doc mode to fail the test suite to crash. Confirmed in 14bd31d that the tests all pass again when these are removed.

Must be some sort of leak somewhere causing these failures.

@user27182
Copy link
Contributor Author

Must be some sort of leak somewhere causing these failures.

Indeed closing all plotters with an autouse fixture resolves this. be7a06e

@user27182 user27182 mentioned this pull request Sep 9, 2025
6 tasks
@user27182 user27182 marked this pull request as ready for review September 9, 2025 19:54
Co-authored-by: user27182 <[email protected]>
@akaszynski
Copy link
Member

Waiting to review until #222 and #223 are merged.

@user27182
Copy link
Contributor Author

Ready for review.

Copy link
Member

@akaszynski akaszynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go.

@akaszynski akaszynski merged commit 8e443ef into main Sep 13, 2025
9 checks passed
@akaszynski akaszynski deleted the feat/doc_mode_generate_subdirs branch September 13, 2025 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants