-
-
Notifications
You must be signed in to change notification settings - Fork 601
Allow multiple cache images for CubeAxesActor tests
#7914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7914 +/- ##
=======================================
Coverage 96.44% 96.44%
=======================================
Files 151 151
Lines 32940 32940
Branches 4140 4140
=======================================
Hits 31770 31770
Misses 566 566
Partials 604 604 |
|
BTW, It should fail, see #8003 Maybe due to self-hosted pypi ? |
|
Maybe it's due to package caching? Might need to use |
Is this a UV or tox thing? Even the numpy nightlies are not being installed: https://github.com/pyvista/pyvista/actions/runs/18485826814/job/52669082524#step:7:48 |
That's correct. I'll resolve that. In the mean time, should we delay merging this PR? |
|
This PR adds tests to ensure VTK less than 9.6 has coverage for CubeAxesActor. And those tests are executing and passing. So I think this is good to merge now. |
Overview
Use feature from pyvista/pytest-pyvista#211 to store multiple cached images for a single test, and add back CubeAxesActor images for vtk < 9.6 that were removed in #7682