Skip to content

Conversation

@user27182
Copy link
Contributor

Overview

Use feature from pyvista/pytest-pyvista#211 to store multiple cached images for a single test, and add back CubeAxesActor images for vtk < 9.6 that were removed in #7682

@pyvista-bot pyvista-bot added the maintenance Low-impact maintenance activity label Sep 2, 2025
@user27182 user27182 added the vtk-dev-testing Enable testing with the latest VTK dev wheels label Sep 3, 2025
@pyvista-bot
Copy link
Contributor

pyvista-bot commented Sep 3, 2025

@pyvista-bot pyvista-bot temporarily deployed to pull request September 3, 2025 06:44 Inactive
@pyvista-bot pyvista-bot temporarily deployed to pull request September 3, 2025 07:52 Inactive
@pyvista-bot pyvista-bot temporarily deployed to pull request September 3, 2025 16:59 Inactive
@codecov
Copy link

codecov bot commented Sep 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.44%. Comparing base (6414a81) to head (84eca3d).
⚠️ Report is 130 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7914   +/-   ##
=======================================
  Coverage   96.44%   96.44%           
=======================================
  Files         151      151           
  Lines       32940    32940           
  Branches     4140     4140           
=======================================
  Hits        31770    31770           
  Misses        566      566           
  Partials      604      604           

@pyvista-bot pyvista-bot temporarily deployed to pull request September 3, 2025 19:16 Inactive
@pyvista-bot pyvista-bot temporarily deployed to pull request September 3, 2025 20:01 Inactive
@pyvista-bot pyvista-bot temporarily deployed to pull request September 5, 2025 03:38 Inactive
@pyvista-bot pyvista-bot temporarily deployed to pull request September 5, 2025 05:19 Inactive
@pyvista-bot pyvista-bot temporarily deployed to pull request October 6, 2025 05:15 Inactive
@pyvista-bot pyvista-bot temporarily deployed to pull request October 14, 2025 02:53 Inactive
@user27182 user27182 marked this pull request as ready for review October 14, 2025 04:48
@pyvista-bot pyvista-bot temporarily deployed to pull request October 14, 2025 05:14 Inactive
@edabor
Copy link
Collaborator

edabor commented Oct 14, 2025

BTW, vtk_dev job does not seem to be correctly pulling the latest vtk.
https://github.com/pyvista/pyvista/actions/runs/18485826814/job/52669082517#step:7:33

It should fail, see #8003

Maybe due to self-hosted pypi ?

@user27182
Copy link
Contributor Author

Maybe it's due to package caching? Might need to use --no-cache ?

@user27182
Copy link
Contributor Author

BTW, vtk_dev job does not seem to be correctly pulling the latest vtk. https://github.com/pyvista/pyvista/actions/runs/18485826814/job/52669082517#step:7:33

It should fail, see #8003

Maybe due to self-hosted pypi ?

Is this a UV or tox thing? Even the numpy nightlies are not being installed:

https://github.com/pyvista/pyvista/actions/runs/18485826814/job/52669082524#step:7:48

@akaszynski
Copy link
Member

Maybe due to self-hosted pypi ?

That's correct. I'll resolve that. In the mean time, should we delay merging this PR?

@user27182
Copy link
Contributor Author

This PR adds tests to ensure VTK less than 9.6 has coverage for CubeAxesActor. And those tests are executing and passing. So I think this is good to merge now.

@pyvista-bot pyvista-bot temporarily deployed to pull request October 15, 2025 17:22 Inactive
@pyvista-bot pyvista-bot temporarily deployed to pull request October 16, 2025 03:36 Inactive
@user27182 user27182 enabled auto-merge (squash) October 17, 2025 15:41
@user27182 user27182 merged commit 8feb648 into main Oct 17, 2025
37 checks passed
@user27182 user27182 deleted the maint/multiple_cache_images branch October 17, 2025 15:56
@pyvista-bot pyvista-bot temporarily deployed to pull request October 17, 2025 15:56 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ignore-for-release maintenance Low-impact maintenance activity vtk-dev-testing Enable testing with the latest VTK dev wheels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants