Implementing AlphaSyndrome into qLDPC#421
Merged
Merged
Conversation
Collaborator
|
Thank you for the contribution! This is a very nice addition to the library. At a glance, the code looks clean, and all checks pass, so I expect review to be fairly straightforward. Even so, please allow me a few weeks to go over the changes in detail 🙂 One minor point to flag: I like the addition of a |
Collaborator
|
Also, @acasta-yhliu I invited you to be a contributor with write access to branches of |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've implemented the AlphaSyndrome syndrome measurement scheduler. A few notes:
src/qLDPC/circuits/alphasyndrome.py.Some other things to be checked: