Skip to content

This closes #2061, fix border styles missing after saved workbook#2064

Merged
xuri merged 1 commit intoqax-os:masterfrom
Arpelicy:bugfix
Jan 4, 2025
Merged

This closes #2061, fix border styles missing after saved workbook#2064
xuri merged 1 commit intoqax-os:masterfrom
Arpelicy:bugfix

Conversation

@Arpelicy
Copy link
Contributor

@Arpelicy Arpelicy commented Jan 4, 2025

PR Details

  • Fix border styles missing after saved workbook
  • Using form template for GitHub issues
  • Typo fix for comments of the getSupportedLanguageInfo function

Related Issue

#2061

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

- Using form template for GitHub issues
- Typo fix for comments of the getSupportedLanguageInfo function
Copy link
Member

@xuri xuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution.

@xuri xuri added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 4, 2025
@codecov
Copy link

codecov bot commented Jan 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.20%. Comparing base (caf22e4) to head (7e6e07e).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2064      +/-   ##
==========================================
- Coverage   99.20%   99.20%   -0.01%     
==========================================
  Files          32       32              
  Lines       30026    30017       -9     
==========================================
- Hits        29788    29779       -9     
  Misses        158      158              
  Partials       80       80              
Flag Coverage Δ
unittests 99.20% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xuri xuri merged commit 4b4d4df into qax-os:master Jan 4, 2025
28 checks passed
xuri pushed a commit that referenced this pull request Mar 4, 2025
)

- Using form template for GitHub issues
- Typo fix for comments of the getSupportedLanguageInfo function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

No open projects
Status: Bugfix

Development

Successfully merging this pull request may close these issues.

How to Resolve the Issue of Original Cell Borders Disappearing When Using Excelize?

2 participants

Comments