try to fix #2086 #2087
Open
try to fix #2086 #2087
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xuri
added
the
size/M
xuri
requested changes
Feb 12, 2025
| @@ -217,6 +217,60 @@ func OpenReader(r io.Reader, opts ...Options) (*File, error) { | |||
| return f, err | |||
| } | |||
|
|
|||
| // StreamRead 流式读取，不支持加密的 Excel 2003 | |||
There was a problem hiding this comment.
Please don't introduce new exported function, just updated OpenReader function. Encrypted workbooks should be supported. Please also update unit tests for these changes.
| // 不支持 加密的 Excel 2003 格式！ | ||
| // openByName read data stream from io.Reader and return a populated | ||
| // spreadsheet file. | ||
| func openByName(name string, opts ...Options) (*File, error) { |
There was a problem hiding this comment.
Any perf data can be shared about these changes? So, we can compare perf before and after changes. For example: CPU, memory usage, disk I/O.
There was a problem hiding this comment.
我在1G内存的pod 中尝试读取10G大小的 Excel 文件，会直接 oom killed，因为 io.ReadAll 会将整个文件加载到内存里面来；
修改后，内存占用稳定在 54M
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
新增
StreamRead可替代 OpenFile，用于真正流式读取 Excel，OpenFile 会调用 OpenReader，OpenReader 会调用 io.ReadAll, 而 io.ReadAll 会将整个文件加载到内存，使流式读取失效；请注意，StreamRead 不支持打开加密的 Excel 2003