Skip to content

reduce memory allocation when possible#2096

Merged
xuri merged 1 commit intoqax-os:masterfrom
artur-chopikian:master
Mar 2, 2025
Merged

reduce memory allocation when possible#2096
xuri merged 1 commit intoqax-os:masterfrom
artur-chopikian:master

Conversation

@artur-chopikian
Copy link
Contributor

@artur-chopikian artur-chopikian commented Feb 27, 2025

PR Details

Redure memory allocation

Description

Skip xml encoding when string is empty

Related Issue

Do not know about it

Motivation and Context

Reduce memory usage

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Mar 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.20%. Comparing base (5264285) to head (cf75c52).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2096   +/-   ##
=======================================
  Coverage   99.20%   99.20%           
=======================================
  Files          32       32           
  Lines       30070    30070           
=======================================
  Hits        29832    29832           
  Misses        158      158           
  Partials       80       80           
Flag Coverage Δ
unittests 99.20% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xuri xuri added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 1, 2025
@xuri xuri moved this to Features in Excelize v2.9.1 Mar 1, 2025
@xuri xuri moved this from Features to Performance in Excelize v2.9.1 Mar 1, 2025
Copy link
Member

@xuri xuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution.

@xuri xuri merged commit c6d161f into qax-os:master Mar 2, 2025
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

No open projects
Status: Performance

Development

Successfully merging this pull request may close these issues.

2 participants

Comments