Skip to content

Fix panic on delete calc chain#2104

Merged
xuri merged 3 commits intoqax-os:masterfrom
hm3248:bug-fix
Mar 16, 2025
Merged

Fix panic on delete calc chain#2104
xuri merged 3 commits intoqax-os:masterfrom
hm3248:bug-fix

Conversation

@hm3248
Copy link
Contributor

@hm3248 hm3248 commented Mar 16, 2025

PR Details

  • Fix panic on delete calc chain
  • Remove XML tags for the CalcPropsOptions data structure
  • Update dependencies modules

Description

  • Fix panic on delete calc chain
  • Remove XML tags for the CalcPropsOptions data structure
  • Update dependencies modules

Related Issue

None

Motivation and Context

  • Fix panic on delete calc chain
  • Remove XML tags for the CalcPropsOptions data structure
  • Update dependencies modules

How Has This Been Tested

All unit tests have been passed

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

hm3248 and others added 2 commits March 16, 2025 09:37
- Remove XML tags for the CalcPropsOptions data structure
- Update dependencies modules
Go 1.23 and later required for upgrade of dependency package `golang.org/x/crypto`
@codecov
Copy link

codecov bot commented Mar 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.20%. Comparing base (d6931a8) to head (952418e).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2104   +/-   ##
=======================================
  Coverage   99.20%   99.20%           
=======================================
  Files          32       32           
  Lines       30102    30104    +2     
=======================================
+ Hits        29864    29866    +2     
  Misses        158      158           
  Partials       80       80           
Flag Coverage Δ
unittests 99.20% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@xuri xuri added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 16, 2025
Copy link
Member

@xuri xuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution.

@xuri xuri merged commit d399e7b into qax-os:master Mar 16, 2025
17 checks passed
moisespsena added a commit to moisespsena-go/excelize that referenced this pull request Mar 23, 2025
…ependency package `golang.org/x/crypto` (qax-os#2104)"

This reverts commit d399e7b.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments